Remove disable from non-windows platforms#5724
Merged
leculver merged 1 commit intodotnet:mainfrom Feb 17, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the platform-based skip for TestEventStreamCleanup so the unit test runs on non-Windows platforms, aligning with the goal of verifying the Linux/macOS segfault fix described in #2223.
Changes:
- Removed the non-Windows
SkipTestExceptionguard fromTestEventStreamCleanup. - Removed the now-unused
System.Runtime.InteropServicesusing.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
The proof of the pudding is in the eating, and CI ate this change. |
max-charlamb
approved these changes
Feb 17, 2026
leculver
added a commit
to leculver/diagnostics
that referenced
this pull request
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2223. I think this works now based on testing, but let's see in CI.