Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the gcdesc.h header from src/shared and cleans up SOS/Strike includes/forward declarations that no longer need it, reducing duplicated/unused shared GC metadata code in this repo.
Changes:
- Deleted
src/shared/gc/gcdesc.hfrom the shared sources. - Removed now-unneeded
gcdesc.hincludes and forward declarations in SOS/Strike. - Updated
src/shared/README.txtto reflect the removed shared file.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/shared/gc/gcdesc.h | Removed the shared copy of gcdesc.h. |
| src/shared/README.txt | Removed the runtime→diagnostics mapping entry for gcdesc.h (and minor whitespace normalization). |
| src/SOS/Strike/sos.h | Removed unused forward declarations for CGCDesc / CGCDescSeries. |
| src/SOS/Strike/sos.cpp | Removed unused #include "gcdesc.h". |
| src/SOS/Strike/gcroot.cpp | Removed unused #include "gcdesc.h". |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
rcj1
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.