Changes to improve SOS test perf

[hoyosjs]

This pull request refactors the Windows dump generation test setup to improve reliability and parallelism. The most significant change is replacing the DumpGenerationFixture xUnit fixture with a static module initializer, ensuring registry keys are set up and cleaned up exactly once per test assembly, which allows tests to run in parallel without serialization. It also splits SOS tests into classes to allow for some level of parallelism (xUnit v2 doesn't support Method level parallelism).

[Copilot]

Pull request overview

Refactors SOS unit test execution to improve reliability and enable more parallelism by moving Windows dump-generation setup to one-time assembly initialization and splitting tests across multiple xUnit classes/collections.

Changes:

• Add xunit.runner.json configuration and copy it to test output to adjust xUnit discovery/execution behavior.
• Refactor dump-generation registry setup from an xUnit fixture/collection into a [ModuleInitializer] + ProcessExit cleanup.
• Split the monolithic SOS test class into multiple test classes and add timing instrumentation; migrate crash-report JSON parsing to System.Text.Json and drop Newtonsoft.Json.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
src/tests/SOS.UnitTests/xunit.runner.json	Adds xUnit runner configuration (disables theory pre-enumeration).
src/tests/SOS.UnitTests/SOS.cs	Splits tests into multiple classes, adds timing logs, introduces Configurations helper, and switches crash-report parsing to System.Text.Json.
src/tests/SOS.UnitTests/SOS.UnitTests.csproj	Ensures xunit.runner.json is copied to output; removes Newtonsoft.Json package reference.
src/tests/SOS.UnitTests/DumpGenerationFixture.cs	Replaces xUnit fixture/collection with module-initializer-based registry setup and ProcessExit cleanup.

Comments suppressed due to low confidence (1)

src/tests/SOS.UnitTests/SOS.cs:259

• TestCrashReport catches all exceptions (including assertion failures) and only logs them, which means crash-report validation can silently pass even when required properties are missing/invalid (e.g., GetProperty(...).GetString() returning null or GetProperty throwing). To keep the extra logging while still failing the test, rethrow after logging (similar to LLDBPluginTests) and/or use TryGetProperty + explicit null assertions for required string values.

            using JsonDocument crashReport = JsonDocument.Parse(File.ReadAllText(crashReportPath));
            JsonElement root = crashReport.RootElement;

            Assert.True(root.TryGetProperty("payload", out JsonElement payload));
            Version protocol_version = Version.Parse(payload.GetProperty("protocol_version").GetString());
            Assert.True(protocol_version >= new Version("1.0.0"));
            outputHelper.IndentedOutput.WriteLine($"protocol_version {protocol_version}");

            string process_name = payload.GetProperty("process_name").GetString();
            Assert.NotNull(process_name);
            outputHelper.IndentedOutput.WriteLine($"process_name {process_name}");

            Assert.True(payload.TryGetProperty("threads", out JsonElement threads));
            int threadCount = threads.GetArrayLength();
            Assert.True(threadCount > 0);
            outputHelper.IndentedOutput.WriteLine($"threads # {threadCount}");

            if (OS.Kind == OSKind.OSX)
            {
                Assert.True(root.TryGetProperty("parameters", out JsonElement parameters));
                Assert.True(parameters.TryGetProperty("ExceptionType", out _));
                Assert.True(parameters.TryGetProperty("OSVersion", out _));
                Assert.Equal("apple", parameters.GetProperty("SystemManufacturer").GetString());
            }
        }
        catch (Exception ex)
        {
            // Log the exception
            outputHelper.IndentedOutput.WriteLine(ex.ToString());
        }

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.