Optimize word count#2974
Merged
Merged
Conversation
live1206
reviewed
Jun 29, 2018
live1206
approved these changes
Jul 2, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LoadHtmlhas huge performance impact, this PR optimizes word count by:Time to build azure-docs-pr (without git contribution info) drops roughly from 6 mins to 3 mins.
Note:
This implementation is slightly different from the original one, but is more correct:
<title>tag because title, it is already removed in markup phaseThis impacts legacy tests, we could consider removing
word_countin as impact test post process.#2972