Skip to content

Ignore __global property for output, it is HUGE#5718

Merged
3 commits merged into
dotnet:v3from
yufeih:global
Apr 2, 2020
Merged

Ignore __global property for output, it is HUGE#5718
3 commits merged into
dotnet:v3from
yufeih:global

Conversation

@yufeih
Copy link
Copy Markdown
Contributor

@yufeih yufeih commented Apr 2, 2020

AB#195827

Profile shows that ToJToken takes an abnormal 24% of total CPU time, additional analysis shows that most of the payload is __global as an example shown here. This PR skips serialization of __global and results in a significant performance improvement of reference pipelines.

Reduces azure-docs-rest-api build time from 2:00 to 1:30 (25%)

Before:
image

After:
image

Microsoft Reviewers: Open in CodeFlow

@yufeih yufeih added the v3 label Apr 2, 2020
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 2, 2020

Codecov Report

Merging #5718 into v3 will increase coverage by 0.00%.
The diff coverage is 88.88%.

Impacted file tree graph

@@           Coverage Diff           @@
##               v3    #5718   +/-   ##
=======================================
  Coverage   92.33%   92.33%           
=======================================
  Files         189      189           
  Lines        7774     7779    +5     
=======================================
+ Hits         7178     7183    +5     
  Misses        596      596           
Impacted Files Coverage Δ
src/docfx/template/MustacheTemplate.cs 95.00% <75.00%> (-2.37%) ⬇️
src/docfx/lib/js/ChakraCoreJsEngine.cs 93.93% <100.00%> (+0.04%) ⬆️
src/docfx/lib/js/JintJsEngine.cs 100.00% <100.00%> (ø)
src/docfx/template/TemplateEngine.cs 98.38% <100.00%> (ø)
src/docfx/publish/PublishModelBuilder.cs 97.60% <0.00%> (+0.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da45e5a...83b1253. Read the comment docs.

@ghost
Copy link
Copy Markdown

ghost commented Apr 2, 2020

DevSandbox(00:00:17.1258603, 3649 more diff)
diff --git "a/D:/Docs.Build.TestData\\DevSandbox\\output/devsandbox/devsandbox-test/browse/certification.raw.page.json" "b/D:/Docs.Build.TestData\\DevSandbox\\.temp/devsandbox/devsandbox-test/browse/certification.raw.page.json"
index 12712a4..8346d5b 100644
--- "a/D:/Docs.Build.TestData\\DevSandbox\\output/devsandbox/devsandbox-test/browse/certification.raw.page.json"
+++ "b/D:/Docs.Build.TestData\\DevSandbox\\.temp/devsandbox/devsandbox-test/browse/certification.raw.page.json"
@@ -18,7 +18,7 @@
 \t<div class=\"columns has-large-gaps\">⬇
 \t\t<div class=\"column is-one-third-tablet is-one-quarter-desktop\">⬇
 \t\t\t<div role=\"region\" aria-labelledby=\"refine-header\">⬇
-\t\t\t\t<h2 id=\"refine-header\" class=\"title is-2 has-margin-top-none\">Filter</h2>⬇
+\t\t\t\t<h2 id=\"refine-header\" class=\"title is-2 has-margin-top-none\"></h2>⬇
 \t\t\t\t<div id=\"refine-content\">⬇
 ⬇
 \t\t\t\t</div>⬇
diff --git "a/D:/Docs.Build.TestData\\DevSandbox\\output/devsandbox/devsandbox-test/browse/course.raw.page.json" "b/D:/Docs.Build.TestData\\DevSandbox\\.temp/devsandbox/devsandbox-test/browse/course.raw.page.json"
index a7eb067..9c3a569 100644
--- "a/D:/Docs.Build.TestData\\DevSandbox\\output/devsandbox/devsandbox-test/browse/course.raw.page.json"
+++ "b/D:/Docs.Build.TestData\\DevSandbox\\.temp/devsandbox/devsandbox-test/browse/course.raw.page.json"
@@ -18,7 +18,7 @@
 \t<div class=\"columns has-large-gaps\">⬇
 \t\t<div class=\"column is-one-third-tablet is-one-quarter-desktop\">⬇
 \t\t\t<div role=\"region\" aria-labelledby=\"refine-header\">⬇
-\t\t\t\t<h2 id=\"refine-header\" class=\"title is-2 has-margin-top-none\">Filter</h2>⬇
+\t\t\t\t<h2 id=\"refine-header\" class=\"title is-2 has-margin-top-none\"></h2>⬇
 \t\t\t\t<div id=\"refine-content\">⬇
 ⬇
 \t\t\t\t</div>⬇
diff --git "a/D:/Docs.Build.TestData\\DevSandbox\\output/devsandbox/devsandbox-test/browse/learn.raw.page.json" "b/D:/Docs.Build.TestData\\DevSandbox\\.temp/devsandbox/devsandbox-test/browse/learn.raw.page.json"
index 155f2e8..4338685 100644
--- "a/D:/Docs.Build.TestData\\DevSandbox\\output/devsandbox/devsandbox-test/browse/learn.raw.page.json"
+++ "b/D:/Docs.Build.TestData\\DevSandbox\\.temp/devsandbox/devsandbox-test/browse/learn.raw.page.json"
@@ -19,7 +19,7 @@
 \t<div class=\"columns has-large-gaps\">⬇
 \t\t<div class=\"column is-one-third-tablet is-one-quarter-desktop\">⬇
 \t\t\t<div role=\"region\" aria-labelledby=\"refine-header\">⬇
-\t\t\t\t<h2 id=\"refine-header\" class=\"title is-2 has-margin-top-none\">Filter</h2>⬇
+\t\t\t\t<h2 id=\"refine-header\" class=\"title is-2 has-margin-top-none\"></h2>⬇
 \t\t\t\t<div id=\"refine-content\">⬇
 ⬇
 \t\t\t\t</div>⬇
diff --git "a/D:/Docs.Build.TestData\\DevSandbox\\output/devsandbox/devsandbox-test/browse/sample.raw.page.json" "b/D:/Docs.Build.TestData\\DevSandbox\\.temp/devsandbox/devsandbox-test/browse/sample.raw.page.json"
index 9d33527..d2a181c 100644
--- "a/D:/Docs.Build.TestData\\DevSandbox\\output/devsandbox/devsandbox-test/browse/sample.raw.page.json"
+++ "b/D:/Docs.Build.TestData\\DevSandbox\\.temp/devsandbox/devsandbox-test/browse/sample.raw.page.json"
@@ -19,7 +19,7 @@
 \t<div class=\"columns has-large-gaps\">⬇
 \t\t<div class=\"column is-one-third-tablet is-one-quarter-desktop\">⬇
 \t\t\t<div role=\"region\" aria-labelledby=\"refine-header\">⬇
-\t\t\t\t<h2 id=\"refine-header\" class=\"title is-2 has-margin-top-none\">Filter</h2>⬇
+\t\t\t\t<h2 id=\"refine-header\" class=\"title is-2 has-margin-top-none\"></h2>⬇
 \t\t\t\t<div id=\"refine-content\">⬇
 ⬇
 \t\t\t\t</div>⬇
diff --git "a/D:/Docs.Build.TestData\\DevSandbox\\output/devsandbox/devsandbox-test/community/index.raw.page.json" "b/D:/Docs.Build.TestData\\DevSandbox\\.temp/devsandbox/devsandbox-test/community/index.raw.page.json"
index 7f56ce2..8ce612a 100644
--- "a/D:/Docs.Build.TestData\\DevSandbox\\output/devsandbox/devsandbox-test/community/index.raw.page.json"
+++ "b/D:/Docs.Build.TestData\\DevSandbox\\.temp/devsandbox/devsandbox-test/community/index.raw.page.json"
@@ -20,7 +20,7 @@
 ⬇
 \t<section class=\"profiles-container uhf-container\">⬇
 \t\t<input id=\"filter-list\" class=\"filter-list\" placeholder=\"Cloud Advocates\" type=\"search\" aria-label=\"Cloud Advocates\">⬇
-\t\t<div class=\"alert is-primary no-results\" hidden=\"\"><p class=\"alert-title\">No results found</p></div>⬇
+\t\t<div class=\"alert is-primary no-results\" hidden=\"\"><p class=\"alert-title\"></div>⬇
 \t\t<ul>⬇
 \t\t\t<li class=\"profile-component\">⬇
 \t\t\t\t<xref href=\"{\r⬇
diff --git "a/D:/Docs.Build.TestData\\DevSandbox\\output/devsandbox/devsandbox-test/community/map.raw.page.json" "b/D:/Docs.Build.TestData\\DevSandbox\\.temp/devsandbox/devsandbox-test/community/map.raw.page.json"
index e457c22..1446c39 100644
--- "a/D:/Docs.Build.TestData\\DevSandbox\\output/devsandbox/devsandbox-test/community/map.raw.page.json"
+++ "b/D:/Docs.Build.TestData\\DevSandbox\\.temp/devsandbox/devsandbox-test/community/map.raw.page.json"
@@ -10,7 +10,7 @@
 \t\t<h1>Cloud Advocates</h1>⬇
 \t\t<div class=\"map-filter-container\">⬇
 \t\t\t<input id=\"filter-list-map\" class=\"filter-list-map input\" placeholder=\"Cloud Advocates\" type=\"search\" aria-label=\"Cloud Advocates\">⬇
-\t\t\t<div class=\"alert is-primary no-results\" hidden=\"\"><p class=\"alert-title\">No results found</p></div>⬇
+\t\t\t<div class=\"alert is-primary no-results\" hidden=\"\"><p class=\"alert-title\"></div>⬇
 \t\t</div>⬇
 \t\t<div id=\"map\" class=\"map\"></div>⬇
 \t</section>⬇
diff --git "a/D:/Docs.Build.TestData\\DevSandbox\\output/devsandbox/devsandbox-test/hub/azure.raw.page.json" "b/D:/Docs.Build.TestData\\DevSandbox\\.temp/devsandbox/devsandbox-test/hub/azure.raw.page.json"
index 1d2a2c6..376ad46 100644
--- "a/D:/Docs.Build.TestData\\DevSandbox\\output/devsandbox/devsandbox-test/hub/azure.raw.page.json"
+++ "b/D:/Docs.Build.TestData\\DevSandbox\\.temp/devsandbox/devsandbox-test/hub/azure.raw.page.json"
@@ -79,10 +79,10 @@
 \t\t\t\t\t\t<nav class=\"is-hidden-mobile\" role=\"navigation\" data-bi-name=\"hub-facet\">⬇
 \t\t\t\t\t\t\t<ul class=\"has-margin-none\">⬇
 \t\t\t\t\t\t\t\t\t<li class=\"is-unstyled \">⬇
-\t\t\t\t\t\t\t\t\t\t<button data-facet=\"all\" class=\"all-facet button has-inner-focus is-full-width has-flex-justify-content-space-between is-text is-small has-text-weight-semibold is-full-width justify-content-\">All</button>⬇
+\t\t\t\t\t\t\t\t\t\t<button data-facet=\"all\" class=\"all-facet button has-inner-focus is-full-width has-flex-justify-content-space-between is-text is-small has-text-weight-semibold is-full-width justify-content-\"></button>⬇
 \t\t\t\t\t\t\t\t\t</li>⬇
 \t\t\t\t\t\t\t\t\t<li class=\"is-unstyled has-border-bottom has-padding-bottom-extra-small has-margin-bottom-extra-small\">⬇
-\t\t\t\t\t\t\t\t\t\t<button data-facet=\"featured\" class=\"featured-facet hub-facet button has-inner-focus is-full-width has-flex-justify-content-space-between is-text is-small has-text-weight-semibold is-full-width justify-content-\">Featured</button>⬇
+\t\t\t\t\t\t\t\t\t\t<button data-facet=\"featured\" class=\"featured-facet hub-facet button has-inner-focus is-full-width has-flex-justify-content-space-between is-text is-small has-text-weight-semibold is-full-width justify-content-\"></button>⬇
 \t\t\t\t\t\t\t\t\t</li>⬇
 \t\t\t\t\t\t\t\t\t<li class=\"is-unstyled\">⬇
 \t\t\t\t\t\t\t\t\t\t<button data-facet=\"ai-machine-learning\" class=\"hub-facet button has-inner-focus is-full-width has-flex-justify-content-space-between is-text is-small has-text-weight-semibold is-full-width justify-content-\">AI + Machine Learning</button>⬇
@@ -154,7 +154,7 @@
 \t\t\t\t\t\t</nav>⬇
 \t\t\t\t\t\t<nav class=\"is-hidden-tablet dropdown\" role=\"navigation\" data-bi-name=\"hub-facet-mobile\">⬇
 \t\t\t\t\t\t\t<button type=\"button\" class=\"dropdown-trigger button is-full-width has-flex-justify-content-space-between\" aria-controls=\"category-navigation-mobile\" aria-expanded=\"false\">⬇
-\t\t\t\t\t\t\t\t<span id=\"category-hub-dropdown\">Featured</span>⬇
+\t\t\t\t\t\t\t\t<span id=\"category-hub-dropdown\"></span>⬇
 \t\t\t\t\t\t\t\t<span class=\"icon\" aria-hidden=\"true\">⬇
 \t\t\t\t\t\t\t\t\t<span class=\"docon docon-chevron-down-light expanded-indicator\"></span>⬇
 \t\t\t\t\t\t\t\t</span>⬇
@@ -162,7 +162,7 @@
 \t\t\t\t\t\t\t<div id=\"category-navigation-mobile\" class=\"dropdown-menu is-full-width has-padding-medium is-size-7 has-body-background-medium\" role=\"menu\">⬇
 \t\t\t\t\t\t\t\t<ul class=\"has-margin-none\">⬇
 \t\t\t\t\t\t\t\t\t\t<li class=\"is-unstyled has-border-bottom has-padding-bottom-extra-small has-margin-bottom-extra-small\">⬇
-\t\t\t\t\t\t\t\t\t\t\t<button class=\"hub-facet dropdown-menu-close button is-full-width has-flex-justify-content-space-between is-text is-small has-text-weight-semibold has-inner-focus\">Featured</button>⬇
+\t\t\t\t\t\t\t\t\t\t\t<button class=\"hub-facet dropdown-menu-close button is-full-width has-flex-justify-content-space-between is-text is-small has-text-weight-semibold has-inner-focus\"></button>⬇
 \t\t\t\t\t\t\t\t\t\t</li>⬇
 \t\t\t\t\t\t\t\t\t\t<li class=\"is-unstyled\">⬇
 \t\t\t\t\t\t\t\t\t\t\t<button data-facet=\"ai-machine-learning\" class=\"hub-facet dropdown-menu-close button is-full-width has-flex-justify-content-space-between is-text is-small has-text-weight-semibold has-inner-focus\">AI + Machine Learning</button>⬇
diff --git "a/D:/Docs.Build.TestData\\DevSandbox\\output/devsandbox/devsandbox-test/learn/certifications/courses/index.raw.page.json" "b/D:/Docs.Build.TestData\\DevSandbox\\.temp/devsandbox/devsandbox-test/learn/certifications/courses/index.raw.page.json"
index 70fda13..d22600d 100644
--- "a/D:/Docs.Build.TestData\\DevSandbox\\output/devsandbox/devsandbox-test/learn/certifications/courses/index.raw.page.json"
+++ "b/D:/Docs.Build.TestData\\DevSandbox\\.temp/devsandbox/devsandbox-test/learn/certifications/courses/index.raw.page.json"
@@ -12,21 +12,21 @@
 \t\t\t\t<div class=\"columns is-mobile is-gapless has-margin-bottom-none\">⬇
 \t\t\t\t\t<div class=\"column is-auto heading-container\">⬇
 \t\t\t\t\t\t<h1 class=\"has-margin-none\">⬇
-\t\t\t\t\t\t\tCourse 40409-A: Deploying Voice Workloads for Skype for Business Online and Server 2015⬇
+\t\t\t\t\t\t\t 40409-A: Deploying Voice Workloads for Skype for Business Online and Server 2015⬇
 \t\t\t\t\t\t</h1>⬇
 \t\t\t\t\t\t<ul class=\"metadata page-metadata\">⬇
 \t\t\t\t\t\t\t<li>1 Day, 16 Hours</li>⬇
-\t\t\t\t\t\t\t<li>Instructor-led training</li>⬇
+\t\t\t\t\t\t\t<li></li>⬇
 \t\t\t\t\t\t\t<li>Advanced</li>⬇
 \t\t\t\t\t\t\t<li>English</li>⬇
 \t\t\t\t\t\t</ul>⬇
 \t\t\t\t\t\t\t<div class=\"alert is-size-7 has-line-height-reset\">⬇
 \t\t\t\t\t\t\t\t<p class=\"has-text-weight-semibold\">⬇
-\t\t\t\t\t\t\t\t\tRetirement date:⬇
+\t\t\t\t\t\t\t\t\t⬇
 \t\t\t\t\t\t\t\t\t<time datetime=\"09/15/2019\">09/15/2019</time>⬇
 \t\t\t\t\t\t\t\t</p>⬇
 \t\t\t\t\t\t\t\t<p class=\"has-margin-top-extra-small\">⬇
-\t\t\t\t\t\t\t\t\tThis course cannot be purchased by Microsoft training partners after this date. Please check with your local or chosen training provider to check availability.⬇
+\t\t\t\t\t\t\t\t\t⬇
 \t\t\t\t\t\t\t\t</p>⬇
 \t\t\t\t\t\t\t</div>⬇
 \t\t\t\t\t</div>⬇
@@ -38,7 +38,7 @@
 </div>⬇
 \t\t\t\t<div class=\"has-line-height-reset course-information has-margin-top-medium\">⬇
 \t\t\t\t\t<div>⬇
-\t\t\t\t\t\t<p class=\"is-size-7 has-margin-none\"><strong>Job role:</strong>⬇
+\t\t\t\t\t\t<p class=\"is-size-7 has-margin-none\"><strong></strong>⬇
 \t\t\t\t\t\t\t\t<span>Administrator</span>⬇
 \t\t\t\t\t\t</p>⬇
 \t\t\t\t\t</div>⬇
@@ -52,14 +52,14 @@
 ⬇
 \t\t\t\t\t<div class=\"related-exams\">⬇
 \t\t\t\t\t\t<p class=\"is-size-7 has-margin-none\">⬇
-\t\t\t\t\t\t\t<strong>Features:</strong>⬇
+\t\t\t\t\t\t\t<strong>:</strong>⬇
 \t\t\t\t\t\t\t<span>none</span>⬇
 \t\t\t\t\t\t</p>⬇
 \t\t\t\t\t</div>⬇
 ⬇
 \t\t\t\t\t<div class=\"has-margin-top-medium\">⬇
 \t\t\t\t\t\t<a href=\"https://www.microsoft.com/en-us/learning/partners.aspx\" class=\"button is-primary\" data-linktype=\"external\">⬇
-\t\t\t\t\t\t\t<span>Find a learning partner</span>⬇
+\t\t\t\t\t\t\t<span></span>⬇
 \t\t\t\t\t\t\t<span class=\"icon\" aria-hidden=\"true\">⬇
 \t\t\t\t\t\t\t\t<span class=\"docon docon-chevron-right-light\"></span>⬇
 \t\t\t\t\t\t\t</span>⬇
@@ -75,7 +75,7 @@
 \t<div class=\"modular-content-container\">⬇
 \t\t<div class=\"section is-small is-uniform\">⬇
 \t\t\t<h2 class=\"has-margin-bottom-extra-small\">⬇
-\t\t\t\tBrowse All Sessions⬇
+\t\t\t\t⬇
 \t\t\t</h2>⬇
 \t\t\t<div class=\"content\">⬇
 ⬇
@@ -87,7 +87,7 @@
 \t<div id=\"skillsGainedContainer\" class=\"modular-content-container\">⬇
 \t\t<div class=\"section is-small is-uniform has-padding-top-none has-body-background-mobile\">⬇
 \t\t\t<h3 class=\"has-margin-top-none has-margin-bottom-extra-small\">⬇
-\t\t\t\tSkills gained⬇
+\t\t\t\t⬇
 \t\t\t</h3>⬇
 \t\t\t<div class=\"content has-margin-top-small has-margin-bottom-none has-padding-none has-line-height-reset\">⬇
 \t\t\t\t<ul id=\"skills-gained\">⬇
@@ -137,7 +137,7 @@
 \t\t<div class=\"modular-content-container\">⬇
 \t\t\t<div class=\"section is-small is-uniform\">⬇
 \t\t\t\t<h2 class=\"has-margin-bottom-extra-small\">⬇
-\t\t\t\t\tPrerequisites⬇
+\t\t\t\t\t⬇
 \t\t\t\t</h2>⬇
 \t\t\t\t<div class=\"content\">⬇
 \t\t\t\t\t<ul>⬇
@@ -158,7 +158,7 @@
 \t\t<div class=\"modular-content-container\">⬇
 \t\t\t<div class=\"section is-small is-uniform\">⬇
 \t\t\t\t<h2 class=\"has-margin-bottom-extra-small\">⬇

@ghost
Copy link
Copy Markdown

ghost commented Apr 2, 2020

azure-docs-pr(00:02:00.3397311, 0 more diff)
diff --git "a/D:/Docs.Build.TestData\\azure-docs-pr\\output/e2eppe-azure-documents/index.raw.page.json" "b/D:/Docs.Build.TestData\\azure-docs-pr\\.temp/e2eppe-azure-documents/index.raw.page.json"
index 5574def..27bf2e4 100644
--- "a/D:/Docs.Build.TestData\\azure-docs-pr\\output/e2eppe-azure-documents/index.raw.page.json"
+++ "b/D:/Docs.Build.TestData\\azure-docs-pr\\.temp/e2eppe-azure-documents/index.raw.page.json"
@@ -79,10 +79,10 @@
 \t\t\t\t\t\t<nav class=\"is-hidden-mobile\" role=\"navigation\" data-bi-name=\"hub-facet\">⬇
 \t\t\t\t\t\t\t<ul class=\"has-margin-none\">⬇
 \t\t\t\t\t\t\t\t\t<li class=\"is-unstyled \">⬇
-\t\t\t\t\t\t\t\t\t\t<button data-facet=\"all\" class=\"all-facet button has-inner-focus is-full-width has-flex-justify-content-space-between is-text is-small has-text-weight-semibold is-full-width justify-content-\">All</button>⬇
+\t\t\t\t\t\t\t\t\t\t<button data-facet=\"all\" class=\"all-facet button has-inner-focus is-full-width has-flex-justify-content-space-between is-text is-small has-text-weight-semibold is-full-width justify-content-\"></button>⬇
 \t\t\t\t\t\t\t\t\t</li>⬇
 \t\t\t\t\t\t\t\t\t<li class=\"is-unstyled has-border-bottom has-padding-bottom-extra-small has-margin-bottom-extra-small\">⬇
-\t\t\t\t\t\t\t\t\t\t<button data-facet=\"featured\" class=\"featured-facet hub-facet button has-inner-focus is-full-width has-flex-justify-content-space-between is-text is-small has-text-weight-semibold is-full-width justify-content-\">Featured</button>⬇
+\t\t\t\t\t\t\t\t\t\t<button data-facet=\"featured\" class=\"featured-facet hub-facet button has-inner-focus is-full-width has-flex-justify-content-space-between is-text is-small has-text-weight-semibold is-full-width justify-content-\"></button>⬇
 \t\t\t\t\t\t\t\t\t</li>⬇
 \t\t\t\t\t\t\t\t\t<li class=\"is-unstyled\">⬇
 \t\t\t\t\t\t\t\t\t\t<button data-facet=\"ai-machine-learning\" class=\"hub-facet button has-inner-focus is-full-width has-flex-justify-content-space-between is-text is-small has-text-weight-semibold is-full-width justify-content-\">AI + Machine Learning</button>⬇
@@ -154,7 +154,7 @@
 \t\t\t\t\t\t</nav>⬇
 \t\t\t\t\t\t<nav class=\"is-hidden-tablet dropdown\" role=\"navigation\" data-bi-name=\"hub-facet-mobile\">⬇
 \t\t\t\t\t\t\t<button type=\"button\" class=\"dropdown-trigger button is-full-width has-flex-justify-content-space-between\" aria-controls=\"category-navigation-mobile\" aria-expanded=\"false\">⬇
-\t\t\t\t\t\t\t\t<span id=\"category-hub-dropdown\">Featured</span>⬇
+\t\t\t\t\t\t\t\t<span id=\"category-hub-dropdown\"></span>⬇
 \t\t\t\t\t\t\t\t<span class=\"icon\" aria-hidden=\"true\">⬇
 \t\t\t\t\t\t\t\t\t<span class=\"docon docon-chevron-down-light expanded-indicator\"></span>⬇
 \t\t\t\t\t\t\t\t</span>⬇
@@ -162,7 +162,7 @@
 \t\t\t\t\t\t\t<div id=\"category-navigation-mobile\" class=\"dropdown-menu is-full-width has-padding-medium is-size-7 has-body-background-medium\" role=\"menu\">⬇
 \t\t\t\t\t\t\t\t<ul class=\"has-margin-none\">⬇
 \t\t\t\t\t\t\t\t\t\t<li class=\"is-unstyled has-border-bottom has-padding-bottom-extra-small has-margin-bottom-extra-small\">⬇
-\t\t\t\t\t\t\t\t\t\t\t<button class=\"hub-facet dropdown-menu-close button is-full-width has-flex-justify-content-space-between is-text is-small has-text-weight-semibold has-inner-focus\">Featured</button>⬇
+\t\t\t\t\t\t\t\t\t\t\t<button class=\"hub-facet dropdown-menu-close button is-full-width has-flex-justify-content-space-between is-text is-small has-text-weight-semibold has-inner-focus\"></button>⬇
 \t\t\t\t\t\t\t\t\t\t</li>⬇
 \t\t\t\t\t\t\t\t\t\t<li class=\"is-unstyled\">⬇
 \t\t\t\t\t\t\t\t\t\t\t<button data-facet=\"ai-machine-learning\" class=\"hub-facet dropdown-menu-close button is-full-width has-flex-justify-content-space-between is-text is-small has-text-weight-semibold has-inner-focus\">AI + Machine Learning</button>⬇

@ghost
Copy link
Copy Markdown

ghost commented Apr 2, 2020

azure-docs-rest-apis(00:02:27.9586343, 379267 more diff)
diff --git "a/D:/Docs.Build.TestData\\azure-docs-rest-apis\\output/e2eppe-azurerestapi/api/advisor/configurations/createinresourcegroup.raw.page.json" "b/D:/Docs.Build.TestData\\azure-docs-rest-apis\\.temp/e2eppe-azurerestapi/api/advisor/configurations/createinresourcegroup.raw.page.json"
index 801610e..cb532e0 100644
--- "a/D:/Docs.Build.TestData\\azure-docs-rest-apis\\output/e2eppe-azurerestapi/api/advisor/configurations/createinresourcegroup.raw.page.json"
+++ "b/D:/Docs.Build.TestData\\azure-docs-rest-apis\\.temp/e2eppe-azurerestapi/api/advisor/configurations/createinresourcegroup.raw.page.json"
@@ -28,7 +28,7 @@
 ⬇
 ⬇
 <nav id=\"center-doc-outline\" class=\"doc-outline is-hidden-desktop\" data-bi-name=\"intopic toc\" role=\"navigation\" aria-label=\"On page navigation\">⬇
-  <h3>In this article</h3>⬇
+  <h3></h3>⬇
 </nav>⬇
 ⬇
 ⬇
@@ -36,7 +36,7 @@
 \t<pre data-interactive=\"http\"><code class=\"lang-http\" dir=\"ltr\">PUT https://management.azure.com/subscriptions/{subscriptionId}/resourceGroups/{resourceGroup}/providers/Microsoft.Advisor/configurations?api-version=2017-04-19</code></pre>⬇
 ⬇
 ⬇
-\t<h2 id=\"uri-parameters\">URI Parameters</h2>⬇
+\t<h2 id=\"uri-parameters\"></h2>⬇
 \t<table class=\"parameters\">⬇
 \t\t<tr>⬇
 \t\t\t<th>Name</th>⬇
@@ -114,7 +114,7 @@
 \t</table>⬇
 ⬇
 ⬇
-\t<h2 id=\"request-body\">Request Body</h2>⬇
+\t<h2 id=\"request-body\"></h2>⬇
 \t\t⬇
 \t\t<table class=\"parameters\">⬇
 \t\t\t<tr>⬇
@@ -193,7 +193,7 @@
     \t</td>⬇
     </tr>\t\t</table>⬇
 ⬇
-\t<h2 id=\"response\">Responses</h2>⬇
+\t<h2 id=\"response\"></h2>⬇
 \t<table class=\"parameters definitions\">⬇
 \t\t<tr>⬇
 \t\t\t<th>Name</th>⬇
@@ -229,7 +229,7 @@
    \t</td>⬇
    </tr>\t</table>⬇
 ⬇
-\t<h2 id=\"security\">Security</h2>⬇
+\t<h2 id=\"security\"></h2>⬇
 \t\t<h3>azure_auth</h3>⬇
 \t\t<p>Azure Active Directory OAuth2 Flow.</p>⬇
 ⬇
@@ -257,7 +257,7 @@
 \t\t\t\t\t</tr>⬇
 \t\t\t</table>⬇
 ⬇
-\t<h2 id=\"examples\">Examples</h2>⬇
+\t<h2 id=\"examples\"></h2>⬇
 \t\t\t<h3 id=\"putconfigurations\">PutConfigurations</h3>⬇
 \t\t<div class=\"example-block\">⬇
 \t\t\t<h4>Sample Request</h4>⬇
@@ -297,7 +297,7 @@
 }</code></pre>⬇
 \t\t\t</div>⬇
 ⬇
-\t<h2 id=\"definitions\">Definitions</h2>⬇
+\t<h2 id=\"definitions\"></h2>⬇
 \t\t<table class=\"nameValue\">⬇
 \t\t\t\t<tr>⬇
 \t\t\t\t\t<td>⬇
diff --git "a/D:/Docs.Build.TestData\\azure-docs-rest-apis\\output/e2eppe-azurerestapi/api/advisor/configurations/createinsubscription.raw.page.json" "b/D:/Docs.Build.TestData\\azure-docs-rest-apis\\.temp/e2eppe-azurerestapi/api/advisor/configurations/createinsubscription.raw.page.json"
index dfe7b57..62b5090 100644
--- "a/D:/Docs.Build.TestData\\azure-docs-rest-apis\\output/e2eppe-azurerestapi/api/advisor/configurations/createinsubscription.raw.page.json"
+++ "b/D:/Docs.Build.TestData\\azure-docs-rest-apis\\.temp/e2eppe-azurerestapi/api/advisor/configurations/createinsubscription.raw.page.json"
@@ -29,7 +29,7 @@ Create/Overwrite Azure Advisor configuration and also delete all configurations
 ⬇
 ⬇
 <nav id=\"center-doc-outline\" class=\"doc-outline is-hidden-desktop\" data-bi-name=\"intopic toc\" role=\"navigation\" aria-label=\"On page navigation\">⬇
-  <h3>In this article</h3>⬇
+  <h3></h3>⬇
 </nav>⬇
 ⬇
 ⬇
@@ -37,7 +37,7 @@ Create/Overwrite Azure Advisor configuration and also delete all configurations
 \t<pre data-interactive=\"http\"><code class=\"lang-http\" dir=\"ltr\">PUT https://management.azure.com/subscriptions/{subscriptionId}/providers/Microsoft.Advisor/configurations?api-version=2017-04-19</code></pre>⬇
 ⬇
 ⬇
-\t<h2 id=\"uri-parameters\">URI Parameters</h2>⬇
+\t<h2 id=\"uri-parameters\"></h2>⬇
 \t<table class=\"parameters\">⬇
 \t\t<tr>⬇
 \t\t\t<th>Name</th>⬇
@@ -93,7 +93,7 @@ Create/Overwrite Azure Advisor configuration and also delete all configurations
 \t</table>⬇
 ⬇
 ⬇
-\t<h2 id=\"request-body\">Request Body</h2>⬇
+\t<h2 id=\"request-body\"></h2>⬇
 \t\t⬇
 \t\t<table class=\"parameters\">⬇
 \t\t\t<tr>⬇
@@ -172,7 +172,7 @@ Create/Overwrite Azure Advisor configuration and also delete all configurations
     \t</td>⬇
     </tr>\t\t</table>⬇
 ⬇
-\t<h2 id=\"response\">Responses</h2>⬇
+\t<h2 id=\"response\"></h2>⬇
 \t<table class=\"parameters definitions\">⬇
 \t\t<tr>⬇
 \t\t\t<th>Name</th>⬇
@@ -208,7 +208,7 @@ Create/Overwrite Azure Advisor configuration and also delete all configurations
    \t</td>⬇
    </tr>\t</table>⬇
 ⬇
-\t<h2 id=\"security\">Security</h2>⬇
+\t<h2 id=\"security\"></h2>⬇
 \t\t<h3>azure_auth</h3>⬇
 \t\t<p>Azure Active Directory OAuth2 Flow.</p>⬇
 ⬇
@@ -236,7 +236,7 @@ Create/Overwrite Azure Advisor configuration and also delete all configurations
 \t\t\t\t\t</tr>⬇
 \t\t\t</table>⬇
 ⬇
-\t<h2 id=\"examples\">Examples</h2>⬇
+\t<h2 id=\"examples\"></h2>⬇
 \t\t\t<h3 id=\"putconfigurations\">PutConfigurations</h3>⬇
 \t\t<div class=\"example-block\">⬇
 \t\t\t<h4>Sample Request</h4>⬇
@@ -276,7 +276,7 @@ Create/Overwrite Azure Advisor configuration and also delete all configurations
 }</code></pre>⬇
 \t\t\t</div>⬇
 ⬇
-\t<h2 id=\"definitions\">Definitions</h2>⬇
+\t<h2 id=\"definitions\"></h2>⬇
 \t\t<table class=\"nameValue\">⬇
 \t\t\t\t<tr>⬇
 \t\t\t\t\t<td>⬇
diff --git "a/D:/Docs.Build.TestData\\azure-docs-rest-apis\\output/e2eppe-azurerestapi/api/advisor/configurations/listbyresourcegroup.raw.page.json" "b/D:/Docs.Build.TestData\\azure-docs-rest-apis\\.temp/e2eppe-azurerestapi/api/advisor/configurations/listbyresourcegroup.raw.page.json"
index 9ab9914..4b3aff7 100644
--- "a/D:/Docs.Build.TestData\\azure-docs-rest-apis\\output/e2eppe-azurerestapi/api/advisor/configurations/listbyresourcegroup.raw.page.json"
+++ "b/D:/Docs.Build.TestData\\azure-docs-rest-apis\\.temp/e2eppe-azurerestapi/api/advisor/configurations/listbyresourcegroup.raw.page.json"
@@ -28,7 +28,7 @@
 ⬇
 ⬇
 <nav id=\"center-doc-outline\" class=\"doc-outline is-hidden-desktop\" data-bi-name=\"intopic toc\" role=\"navigation\" aria-label=\"On page navigation\">⬇
-  <h3>In this article</h3>⬇
+  <h3></h3>⬇
 </nav>⬇
 ⬇
 ⬇
@@ -36,7 +36,7 @@
 \t<pre data-interactive=\"http\"><code class=\"lang-http\" dir=\"ltr\">GET https://management.azure.com/subscriptions/{subscriptionId}/resourceGroups/{resourceGroup}/providers/Microsoft.Advisor/configurations?api-version=2017-04-19</code></pre>⬇
 ⬇
 ⬇
-\t<h2 id=\"uri-parameters\">URI Parameters</h2>⬇
+\t<h2 id=\"uri-parameters\"></h2>⬇
 \t<table class=\"parameters\">⬇
 \t\t<tr>⬇
 \t\t\t<th>Name</th>⬇
@@ -115,7 +115,7 @@
 ⬇
 ⬇
 ⬇
-\t<h2 id=\"response\">Responses</h2>⬇
+\t<h2 id=\"response\"></h2>⬇
 \t<table class=\"parameters definitions\">⬇
 \t\t<tr>⬇
 \t\t\t<th>Name</th>⬇
@@ -141,7 +141,7 @@
    \t</td>⬇
    </tr>\t</table>⬇
 ⬇
-\t<h2 id=\"security\">Security</h2>⬇
+\t<h2 id=\"security\"></h2>⬇
 \t\t<h3>azure_auth</h3>⬇
 \t\t<p>Azure Active Directory OAuth2 Flow.</p>⬇
 ⬇
@@ -169,7 +169,7 @@
 \t\t\t\t\t</tr>⬇
 \t\t\t</table>⬇
 ⬇
-\t<h2 id=\"examples\">Examples</h2>⬇
+\t<h2 id=\"examples\"></h2>⬇
 \t\t\t<h3 id=\"getconfigurations\">GetConfigurations</h3>⬇
 \t\t<div class=\"example-block\">⬇
 \t\t\t<h4>Sample Request</h4>⬇
@@ -201,7 +201,7 @@
 }</code></pre>⬇
 \t\t\t</div>⬇
 ⬇
-\t<h2 id=\"definitions\">Definitions</h2>⬇
+\t<h2 id=\"definitions\"></h2>⬇
 \t\t<table class=\"nameValue\">⬇
 \t\t\t\t<tr>⬇
 \t\t\t\t\t<td>⬇
diff --git "a/D:/Docs.Build.TestData\\azure-docs-rest-apis\\output/e2eppe-azurerestapi/api/advisor/configurations/listbysubscription.raw.page.json" "b/D:/Docs.Build.TestData\\azure-docs-rest-apis\\.temp/e2eppe-azurerestapi/api/advisor/configurations/listbysubscription.raw.page.json"
index cf302f5..256d0d8 100644
--- "a/D:/Docs.Build.TestData\\azure-docs-rest-apis\\output/e2eppe-azurerestapi/api/advisor/configurations/listbysubscription.raw.page.json"
+++ "b/D:/Docs.Build.TestData\\azure-docs-rest-apis\\.temp/e2eppe-azurerestapi/api/advisor/configurations/listbysubscription.raw.page.json"
@@ -29,7 +29,7 @@ Retrieve Azure Advisor configurations and also retrieve configurations of contai
 ⬇
 ⬇
 <nav id=\"center-doc-outline\" class=\"doc-outline is-hidden-desktop\" data-bi-name=\"intopic toc\" role=\"navigation\" aria-label=\"On page navigation\">⬇

Copy link
Copy Markdown
Contributor

@mingwli mingwli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ghost ghost merged commit d9644b8 into dotnet:v3 Apr 2, 2020
@yufeih yufeih deleted the global branch April 2, 2020 05:28
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants