fix: replace unresolved crefs with the cref-value instead of just rem…#7325
Merged
superyyrrzz merged 1 commit intodotnet:devfrom Jun 9, 2021
Merged
fix: replace unresolved crefs with the cref-value instead of just rem…#7325superyyrrzz merged 1 commit intodotnet:devfrom
superyyrrzz merged 1 commit intodotnet:devfrom
Conversation
|
@herohua: The issue is the only thing keeping me from adopting docfx, and this fix looks like an easy win. Could we get a review, please? |
superyyrrzz
approved these changes
Jun 9, 2021
Contributor
|
@Algorithman @Emdot Sorry for the terrible late review... The change looks good. Thanks for contribution! |
|
Hello @superyyrrzz was this fix ever shipped with DocFX? We are facing the same problem in the npgsql repo. All |
|
Same problem here with my Unity package docs:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…oving them
fixes #7245