Skip to content

In steps/clean-acr-images, use dryRunArg to fit pipeline usage#2035

Merged
lbussell merged 1 commit intodotnet:mainfrom
dagood:dev/dagood/no-dry
Mar 18, 2026
Merged

In steps/clean-acr-images, use dryRunArg to fit pipeline usage#2035
lbussell merged 1 commit intodotnet:mainfrom
dagood:dev/dagood/no-dry

Conversation

@dagood
Copy link
Copy Markdown
Member

@dagood dagood commented Mar 18, 2026

Seemed to work when temporarily applied onto the copied files for a Go cleanup pipeline. (Run)

@dagood dagood requested a review from a team as a code owner March 18, 2026 21:29
@dagood
Copy link
Copy Markdown
Member Author

dagood commented Mar 18, 2026

Seemed to work

Confirmed that running the pipeline again detected and cleaned up no images.

@lbussell
Copy link
Copy Markdown
Member

Confirmed that running the pipeline again detected and cleaned up no images.

@dagood Is cleaning up no images a good thing, in this instance? Or should it have cleaned up some images?

@dagood
Copy link
Copy Markdown
Member Author

dagood commented Mar 18, 2026

Ha, right--it's good. When we were unintentionally dry running, the cleanup pipeline reported that it (supposedly) cleaned up the same set of images every time, across a few runs. After this change, the first non-dry-run actually cleaned up images, so the second non-dry-run didn't see anything to clean up.

I'm inferring success based on that change in the logs because it's nontrivial for me to manually, directly check the prod resource to see if the cleanup actually happened. 😄

(The "--dry-run" arg also doesn't show up in our logs anymore, which is probably plenty of proof. But, the change in what the build saw in our ACR seems like a more end-to-end indicator.)

@lbussell lbussell merged commit 7dfd195 into dotnet:main Mar 18, 2026
20 checks passed
@dagood dagood deleted the dev/dagood/no-dry branch March 18, 2026 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The steps/clean-acr-images.yml template always runs in dry run mode when called by stages/cleanup-acr-images.yml

2 participants