Do not copy referrers in CopyBaseImages#2073
Merged
lbussell merged 2 commits intodotnet:mainfrom Apr 10, 2026
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
mthalman
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hypothesis:
CopyBaseImagesis timing out due to network isolation restrictions when reaching out to DockerHub. Even though #2071 failed to provide the improved logging that I want (#2072 is follow-up for that), I still believe that network isolation is the cause, because dotnet/dotnet-docker#7141 has the same timeout symptom when reaching out to DH, in a completely different scenario (a Dockerfile build).Even though I do not have concrete logs showing that the network isolation is the cause, I am submitting this PR now in order to unblock servicing/staging images asap.
This PR adds a required
bool copyReferrersparameter toICopyImageService.ImportImageAsyncso callers must explicitly opt in or out of referrer copying. It disables the referrer lookup and copy inCopyBaseImages. At the moment we do not use referrer artifacts from base images for any reason, so there is no downside.AI generated change summary
ICopyImageService/CopyImageService— Added requiredcopyReferrersparameter. Whenfalse, skips bothGetReferrersAsyncand the referrer import loop.CopyBaseImagesCommand— PassescopyReferrers: false.CopyAcrImagesCommand/BuildCommand— PasscopyReferrers: true(preserving existing behavior).ImportImageAsync_CopyReferrersFalse_SkipsReferrerDiscoveryAndImport; updated all existing mock verifications to pass the new parameter explicitly.