Skip to content

Conversation

@ignispotentia
Copy link
Contributor

Summary

Adds missing letter to the first link of the document.

Fixes #66

Copy link
Contributor

@adegeo adegeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, Thanks!

@adegeo adegeo added the ✨ 1st-time docs contributor! Indicates PRs from new contributors to the docs repository label Oct 12, 2020
@adegeo adegeo merged commit b98f4b8 into dotnet:live Oct 12, 2020
@adegeo
Copy link
Contributor

adegeo commented Oct 12, 2020

@ignispotentia ACK! I just noticed this was pointing to the LIVE branch, this should be the MASTER branch. I'll revert this. 😿

@ignispotentia
Copy link
Contributor Author

Didn't want to change anything, so I just took the default values that Github gave me when I edited 😂 it's probably my fault also a little bit.

@adegeo
Copy link
Contributor

adegeo commented Oct 12, 2020

HRM yes I'll have to check that, it should have (in the issue opened) pointed to master.

@ignispotentia
Copy link
Contributor Author

No worries, glad we found it out in time 😁

adegeo added a commit that referenced this pull request Oct 12, 2020
Fix missing letter in first link of article (#68)
@adegeo
Copy link
Contributor

adegeo commented Oct 12, 2020

Awesome. Found the config to adjust that so future comments appear to target the correct branch 😄 #70 thanks for forcing me to uncover that error hahaha.

@ignispotentia
Copy link
Contributor Author

ignispotentia commented Oct 12, 2020

Awesome! And haha, considering the number of times MSDN docs helped me, this is the least I could do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✨ 1st-time docs contributor! Indicates PRs from new contributors to the docs repository

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants