Update windows-prerequisites.md #1385
Conversation
|
Hi @jchannon, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! The agreement was validated by .NET Foundation and real humans are currently evaluating your PR. TTYL, DNFBOT; |
docs/core/windows-prerequisites.md
Outdated
| ## .NET Core dependencies | ||
|
|
||
| .NET Core requires the VC++ Redistributable when running on Windows. It is installed for you by the .NET Core installer. You need to install the Visual C++ redistributable manually if you are installing .NET Core via the installer script (`dotnet-install.ps1`). | ||
| .NET Core requires the VC++ Redistributable when running on Windows. It is installed for you by the .NET Core installer. You need to install the Visual C++ redistributable manually if you are installing .NET Core via the installer script (`dotnet-install.ps1`) or are attempting to run a compiled stand alone .NET Core application. |
There was a problem hiding this comment.
This article calls it "self-contained", not "stand alone". I think the terminology should be consistent.
Also, not sure what "compiled" is supposed to mean here, all self-contained apps are compiled.
So, I would change this to:
… or are attempting to run a self-contained .NET Core application.
I'm also wondering if a link to the article I linked above would be useful here.
|
@svick updated. Also added another commit after discussing the docs with @gkhanna79 on https://github.com/dotnet/cli/issues/195 |
There was a problem hiding this comment.
Thanks @jchannon! I've left a few comments. @blackdwarf @gkhanna79 do you guys want to review this?
docs/core/windows-prerequisites.md
Outdated
| --- | ||
|
|
||
| # Prerequisites for Windows development | ||
| # Prerequisites for Windows development and/or running .Net Core applications |
There was a problem hiding this comment.
.NET needs to be all caps
How about we change the title to something like "Prerequisites for .NET Core on Windows"?
| # Prerequisites for Windows development | ||
| # Prerequisites for Windows development and/or running .Net Core applications | ||
|
|
||
| .NET Core development on Windows with Visual Studio requires: |
There was a problem hiding this comment.
I'd probably change a few sections around. For example, I'd move this info to the Visual Studio section down below and leave the general info that applies to .NET Core on Windows up here. But I can make the changes for you after we merge this.
docs/core/windows-prerequisites.md
Outdated
| * Windows 10 | ||
| * [Visual C++ Redistributable for Visual Studio 2015](https://www.microsoft.com/en-us/download/details.aspx?id=48145) | ||
| * Windows 7+ (not Windows 10) | ||
| * Windows 7 & 2008 only |
There was a problem hiding this comment.
Windows 7 & 2008 -> Windows 7 and Windows 2008
|
@mairaw updated 😄 |
|
Thanks. How soon until it appears on the live docs site?
…On 4 January 2017 at 20:00, Maira Wenzel ***@***.***> wrote:
Merged #1385 <#1385>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1385 (comment)>, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/AAGapjrvQnQegJnOGrayS4zHPWM-uAghks5rO_pDgaJpZM4La3vH>
.
|
|
We need to merge the changes to the live branch. We just did one a few hours ago. We're close to get a few more PRs merged and then we can publish live again. So probably later today. |
|
I was planning to run the script to update live later this evening (Eastern time) |
6 participants
Summary
Updates windows pre-requisuites after finding an issue with compiled stand alone .net core applications
See here https://github.com/dotnet/cli/issues/5201 https://github.com/dotnet/cli/issues/195
Details
When trying to run a stand alone application I received an error as shown in https://github.com/dotnet/cli/issues/5201 A comment was made in https://github.com/dotnet/cli/issues/195 that says Visual C++ is a dependency so this PR elaborates on existing docs for the scenario where you have a stand alone app.