Clarify when methods should end in Async #10734
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using corrected text suggested in bug on the in-product recommendation.
rpetrusha
approved these changes
Feb 26, 2019
There was a problem hiding this comment.
Thanks, @kendrahavens. Your changes look good. The .NET Guide also includes a section on naming conventions in Task-based asynchronous pattern (TAP). I'll open a PR to modify it and request you review it. I'll also merge your PR now.
This was referenced Feb 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using corrected text suggested in bug on the in-product recommendation.
Summary
"Async" shouldn't always be appended to a method name in cases of an overloaded methods or for methods that start an asynchronous operation, but do not actually return an awaitable type. Updated guidance to reflect these cases.