Skip to content

Conversation

rpetrusha
Copy link
Contributor

Revised string best practices for concatenation, interpolated strings

Fixes #11429

Related to dotnet/samples#865

@rpetrusha rpetrusha added the 🚧 Hold for related PR Indicates a PR can only be merged when other related PRs are merged (see comments for links) label May 2, 2019
@rpetrusha rpetrusha self-assigned this May 2, 2019
@BillWagner BillWagner changed the base branch from staging to master May 6, 2019 15:44
@rpetrusha
Copy link
Contributor Author

Closing and reopening to begin new build after dotnet/samples#865 is merged.

@rpetrusha rpetrusha closed this May 13, 2019
@rpetrusha rpetrusha reopened this May 13, 2019
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @rpetrusha

You can :shipit: when you are ready.

Thanks for catching the omission and the typo, @BillWagner.

Co-Authored-By: Bill Wagner <wiwagn@microsoft.com>
@rpetrusha rpetrusha added verify-build-before-merge and removed 🚧 Hold for related PR Indicates a PR can only be merged when other related PRs are merged (see comments for links) labels May 24, 2019
@rpetrusha rpetrusha merged commit 86e0829 into dotnet:master May 24, 2019
@rpetrusha rpetrusha deleted the string-practices branch May 24, 2019 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Interpolation and concatenation too

3 participants