Skip to content

C91896: Deleting extra backslahes #12548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 28, 2019
Merged

C91896: Deleting extra backslahes #12548

merged 2 commits into from
May 28, 2019

Conversation

@v-makoud
Copy link
Contributor

Localization team has reported source content issue that causes localized version to have broken/different format compared to en-us version.

@v-makoud
C91896: Deleting extra backslahes
b140828 
Localization team has reported source content issue that causes localized version to have broken/different format compared to en-us version.
@v-makoud v-makoud requested a review from nishanil as a code owner May 28, 2019 10:23
@v-makoud
Copy link
Contributor Author

#sign-off

@rpetrusha rpetrusha added this to the May 2019 milestone May 28, 2019
@rpetrusha
Copy link
Contributor

The \ character was used to introduce a line break, @v-makoud. I've added two spaces instead, which should have the same effect. I'll merge when the build completes successfully.

rpetrusha
rpetrusha approved these changes May 28, 2019
View reviewed changes
Copy link
Contributor

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build looks good, so I'll merge, @v-makoud.

@rpetrusha rpetrusha merged commit f4665bc into dotnet:master May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nishanil nishanil Awaiting requested review from nishanil

1 more reviewer

@rpetrusha rpetrusha rpetrusha approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@v-makoud v-makoud

Labels

None yet

Projects

None yet

Milestone

May 2019

Development

Successfully merging this pull request may close these issues.

3 participants

@v-makoud @rpetrusha @mairaw