Skip to content

Conversation

@M-Lipin
Copy link
Contributor

@M-Lipin M-Lipin commented Aug 16, 2019

Summary

Adding Accessibility doc for Core WinForms which describes the changes made in WinForms accessibility in comparison with .NET Framework 4.8 https://github.com/microsoft/dotnet/tree/master/Documentation/compatibility

https://github.com/microsoft/dotnet/blob/master/Documentation/compatibility/winforms-accessibility-changes-48.md

Fixes #13870

@rpetrusha
Copy link
Contributor

There's not really a home for this article right now. Ultimately, it will have to go in the .NET Core Guide. I've created #13893 to do that.

Copy link
Contributor

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left a number of comments, @M-Lipin. This article more closely needs to resemble What's new in accessibility in .NET Framework than the old compatibility items in the Microsoft/dotnet repo. I'll do another review once these changes are made.

@rpetrusha
Copy link
Contributor

//cc @Thraka

@RussKie
Copy link
Contributor

RussKie commented Aug 20, 2019

It could be a good idea to wrap control names into `, e.g. ...`ListBox` control...

@M-Lipin M-Lipin requested a review from Thraka as a code owner November 7, 2019 13:59
@Thraka
Copy link
Contributor

Thraka commented Nov 7, 2019

@M-Lipin Hello. There are a few changes you should accept as suggested by Ron. Also, we have a linter running to ensure that the markdown content we accept is well formed. Can you please address those? If you're using VSCode you should be getting the linter rules if you open the repo root. Also, you can see the lint results in the Checks tab at the top.

@Thraka Thraka assigned Thraka and M-Lipin and unassigned Thraka Nov 7, 2019
@M-Lipin M-Lipin changed the title Adding Accessibility doc for Core WinForms WIP: Adding Accessibility doc for Core WinForms Nov 19, 2019
M-Lipin and others added 2 commits December 4, 2019 15:39
Co-Authored-By: Igor Velikorossov <RussKie@users.noreply.github.com>
@Thraka Thraka self-requested a review December 5, 2019 05:57
@Thraka
Copy link
Contributor

Thraka commented Jan 29, 2020

@M-Lipin Hello. Sorry about losing sight of this pull request over the holiday season. We had previously implemented a linter to ensure we have constant structure in the markdown used. There are a few changes that need to happen. Would you prefer it if I edited your doc to fix these problems and ultimately get this pushed through? Or would you rather fix them yourself?

Let me know.

@M-Lipin
Copy link
Contributor Author

M-Lipin commented Feb 20, 2020

Hello @Thraka sorry for the late response. I can fix the document issues. Could you please point me to the issues/requirements or sample how to fix?

@tdykstra
Copy link
Contributor

@M-Lipin here are the markdownlint error messages that @Thraka was referring to. Fixing them just involves making sure there's a blank line before and after a list.

docs/framework/winforms/windows-forms-accessibility-improvements.md:13 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "- Changes in various areas of ..."]
docs/framework/winforms/windows-forms-accessibility-improvements.md:26 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "- Enabled UIA support for List..."]
docs/framework/winforms/windows-forms-accessibility-improvements.md:31 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "- Corrected CheckedListBox Bou..."]
docs/framework/winforms/windows-forms-accessibility-improvements.md:36 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "- Updated the process of getti..."]
docs/framework/winforms/windows-forms-accessibility-improvements.md:40 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "- Corrected DataGridView Bound..."]
docs/framework/winforms/windows-forms-accessibility-improvements.md:47 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "- Corrected PropertyGrid Bound..."]
docs/framework/winforms/windows-forms-accessibility-improvements.md:52 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "- Improved navigation through ..."]
docs/framework/winforms/windows-forms-accessibility-improvements.md:57 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "- Improved accessible navigati..."]
docs/framework/winforms/windows-forms-accessibility-improvements.md:65 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "- Added UI Automation server p..."]
docs/framework/winforms/windows-forms-accessibility-improvements.md:72 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "- Added ability to announce a ..."]

@Thraka
Copy link
Contributor

Thraka commented Feb 20, 2020

@M-Lipin I'm starting on some WinForms planning for .NET Core content. I can jump in here and fix this up for you today. Is that OK?

@M-Lipin
Copy link
Contributor Author

M-Lipin commented Mar 12, 2020

@M-Lipin I'm starting on some WinForms planning for .NET Core content. I can jump in here and fix this up for you today. Is that OK?

It would be great. Thank you!

Co-Authored-By: Ron Petrusha <10886961+rpetrusha@users.noreply.github.com>
@Thraka Thraka added the P1 label Apr 20, 2020
@Thraka
Copy link
Contributor

Thraka commented Apr 20, 2020

Completing this today so I can continue with the desktop guide winforms planning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WinForms Accessibility Documentation

7 participants