-
Notifications
You must be signed in to change notification settings - Fork 6.1k
WIP: Adding Accessibility doc for Core WinForms #13871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Adding Accessibility doc for Core WinForms #13871
Conversation
|
There's not really a home for this article right now. Ultimately, it will have to go in the .NET Core Guide. I've created #13893 to do that. |
rpetrusha
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left a number of comments, @M-Lipin. This article more closely needs to resemble What's new in accessibility in .NET Framework than the old compatibility items in the Microsoft/dotnet repo. I'll do another review once these changes are made.
docs/framework/winforms/windows-forms-accessibility-improvements.md
Outdated
Show resolved
Hide resolved
docs/framework/winforms/windows-forms-accessibility-improvements.md
Outdated
Show resolved
Hide resolved
docs/framework/winforms/windows-forms-accessibility-improvements.md
Outdated
Show resolved
Hide resolved
docs/framework/winforms/windows-forms-accessibility-improvements.md
Outdated
Show resolved
Hide resolved
docs/framework/winforms/windows-forms-accessibility-improvements.md
Outdated
Show resolved
Hide resolved
docs/framework/winforms/windows-forms-accessibility-improvements.md
Outdated
Show resolved
Hide resolved
docs/framework/winforms/windows-forms-accessibility-improvements.md
Outdated
Show resolved
Hide resolved
docs/framework/winforms/windows-forms-accessibility-improvements.md
Outdated
Show resolved
Hide resolved
docs/framework/winforms/windows-forms-accessibility-improvements.md
Outdated
Show resolved
Hide resolved
docs/framework/winforms/windows-forms-accessibility-improvements.md
Outdated
Show resolved
Hide resolved
|
//cc @Thraka |
|
It could be a good idea to wrap control names into |
|
@M-Lipin Hello. There are a few changes you should accept as suggested by Ron. Also, we have a linter running to ensure that the markdown content we accept is well formed. Can you please address those? If you're using VSCode you should be getting the linter rules if you open the repo root. Also, you can see the lint results in the Checks tab at the top. |
docs/framework/winforms/windows-forms-accessibility-improvements.md
Outdated
Show resolved
Hide resolved
docs/framework/winforms/windows-forms-accessibility-improvements.md
Outdated
Show resolved
Hide resolved
docs/framework/winforms/windows-forms-accessibility-improvements.md
Outdated
Show resolved
Hide resolved
docs/framework/winforms/windows-forms-accessibility-improvements.md
Outdated
Show resolved
Hide resolved
Co-Authored-By: Igor Velikorossov <RussKie@users.noreply.github.com>
…h MenuStrip term.
|
@M-Lipin Hello. Sorry about losing sight of this pull request over the holiday season. We had previously implemented a linter to ensure we have constant structure in the markdown used. There are a few changes that need to happen. Would you prefer it if I edited your doc to fix these problems and ultimately get this pushed through? Or would you rather fix them yourself? Let me know. |
|
Hello @Thraka sorry for the late response. I can fix the document issues. Could you please point me to the issues/requirements or sample how to fix? |
|
@M-Lipin here are the markdownlint error messages that @Thraka was referring to. Fixing them just involves making sure there's a blank line before and after a list. docs/framework/winforms/windows-forms-accessibility-improvements.md:13 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "- Changes in various areas of ..."] |
|
@M-Lipin I'm starting on some WinForms planning for .NET Core content. I can jump in here and fix this up for you today. Is that OK? |
It would be great. Thank you! |
Co-Authored-By: Ron Petrusha <10886961+rpetrusha@users.noreply.github.com>
|
Completing this today so I can continue with the desktop guide winforms planning. |
Summary
Adding Accessibility doc for Core WinForms which describes the changes made in WinForms accessibility in comparison with .NET Framework 4.8 https://github.com/microsoft/dotnet/tree/master/Documentation/compatibility
https://github.com/microsoft/dotnet/blob/master/Documentation/compatibility/winforms-accessibility-changes-48.md
Fixes #13870