-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Adding Keyword: parameter array #16233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| f1_keywords: | ||
| - "params_CSharpKeyword" | ||
| - "params" | ||
| - "parameter array" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should probably be removed. It has to correlate to an actual keyword in the product.
| # params (C# Reference) | ||
|
|
||
| By using the `params` keyword, you can specify a [method parameter](method-parameters.md) that takes a variable number of arguments. | ||
| By using the `params` keyword, you can specify an array of [method parameter](method-parameters.md) that takes a variable number of arguments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sentence no longer makes sense. I would leave it as is and instead add "parameter array" to the title metadata.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gewarren Are you suggesting changing the title from "params keyword - C# Reference" to "params keyword parameter array- C# Reference"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest "params keyword for parameter arrays - C# reference".
|
@AndrewCook Do you want to update this based on @gewarren 's comments? Once you do that, we'll |
gewarren
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a couple comments. I think this first few paragraphs could use some other touch-ups, but that isn't directly related to the issue that's being fixed in this PR.
| # params (C# Reference) | ||
|
|
||
| By using the `params` keyword, you can specify a [method parameter](method-parameters.md) that takes a variable number of arguments. | ||
| By using the `params` keyword, you can specify an array of [method parameter](method-parameters.md) that takes a variable number of arguments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest "params keyword for parameter arrays - C# reference".
|
@BillWagner Could you review the changes I made? |
|
Ping @BillWagner. |
BillWagner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updated changes @AndrewCook and @gewarren
I'll
now.
Summary
Adding parameter array keywords and text.
Fixes #12574 (if available)