Skip to content

Conversation

@AndrewCook
Copy link
Contributor

Summary

Adding parameter array keywords and text.

Fixes #12574 (if available)

f1_keywords:
- "params_CSharpKeyword"
- "params"
- "parameter array"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should probably be removed. It has to correlate to an actual keyword in the product.

# params (C# Reference)

By using the `params` keyword, you can specify a [method parameter](method-parameters.md) that takes a variable number of arguments.
By using the `params` keyword, you can specify an array of [method parameter](method-parameters.md) that takes a variable number of arguments.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sentence no longer makes sense. I would leave it as is and instead add "parameter array" to the title metadata.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gewarren Are you suggesting changing the title from "params keyword - C# Reference" to "params keyword parameter array- C# Reference"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest "params keyword for parameter arrays - C# reference".

@BillWagner BillWagner modified the milestones: December 2019, January 2020 Jan 2, 2020
@gewarren gewarren changed the title Adding Keyord: parameter array Adding Keyword: parameter array Feb 12, 2020
@BillWagner BillWagner modified the milestones: January 2020, March 2020 Mar 3, 2020
@BillWagner BillWagner added the ✨ 1st-time docs contributor! Indicates PRs from new contributors to the docs repository label Mar 31, 2020
@BillWagner
Copy link
Member

@AndrewCook Do you want to update this based on @gewarren 's comments? Once you do that, we'll :shipit:

Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a couple comments. I think this first few paragraphs could use some other touch-ups, but that isn't directly related to the issue that's being fixed in this PR.

# params (C# Reference)

By using the `params` keyword, you can specify a [method parameter](method-parameters.md) that takes a variable number of arguments.
By using the `params` keyword, you can specify an array of [method parameter](method-parameters.md) that takes a variable number of arguments.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest "params keyword for parameter arrays - C# reference".

@BillWagner BillWagner modified the milestones: March 2020, April 2020 Apr 6, 2020
@gewarren gewarren dismissed their stale review April 8, 2020 17:45

I updated the file.

@gewarren
Copy link
Contributor

gewarren commented Apr 8, 2020

@BillWagner Could you review the changes I made?

@gewarren
Copy link
Contributor

Ping @BillWagner.

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updated changes @AndrewCook and @gewarren

I'll :shipit: now.

@BillWagner BillWagner merged commit 6333e0b into dotnet:master Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dotnet-csharp/svc ✨ 1st-time docs contributor! Indicates PRs from new contributors to the docs repository

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Params, Splat, every language has a different term for this

4 participants