Skip to content

Conversation

mairaw
Copy link
Contributor

@mairaw mairaw commented Feb 4, 2020

No description provided.

mairaw and others added 11 commits December 10, 2019 16:41
* add toc.yml

* fix toc.yml

* remove extra line

Co-authored-by: Maira Wenzel <mairaw@microsoft.com>
* 2a). Delete C# and VB sample files, add redirects

* 2b). Add merged sample files

* 2c). Add back toc.yml

* add redirect value

* remove spaces on last line

* remove spaces from last line

* Update sample-xml-file-numerical-data.md

* title + small fixes

* fix path

Co-authored-by: Maira Wenzel <mairaw@microsoft.com>
* 3a). Add topic files 1 to 2

* fix typos

* more changes

* toc fixes

* more fixes

* fix broken link

* add redirect

* expand VB

* undo changes

* change link

* more fixes

* content fixes

* acrolinx fixes

* acrolinx

* add breadcrumb

Co-authored-by: Maira Wenzel <mairaw@microsoft.com>
* 4a). Add topic files 3 to 4

* changes

* add redirect true

* title case

Co-authored-by: Maira Wenzel <mairaw@microsoft.com>
* 5a). Add topic files 5 to 6

* add redirect true

* move files to linq folder

* white space + links

* changes

Co-authored-by: Maira Wenzel <mairaw@microsoft.com>
* 6a). Add topic files 7 to 8

* fixes + acrolynx

Co-authored-by: Maira Wenzel <mairaw@microsoft.com>
* 7a). Add topic files 9 to 10

* add redirect true

* move files to linq folder

* acrolinx + fixes

* link format

Co-authored-by: Maira Wenzel <mairaw@microsoft.com>
mairaw and others added 8 commits February 10, 2020 10:39
* 9). Add topic files 11 to 14

* fix path

Co-authored-by: Maira Wenzel <mairaw@microsoft.com>
* 10). Add topic files 15 to 18

* small edits

* small edits

* use link

* small edits

* add missing desciption

Co-authored-by: Maira Wenzel <mairaw@microsoft.com>
* 11). Add topic files 19 to 22

* fix path

* small edits

* small edits

* small edit

* small edits

* small edit

Co-authored-by: Maira Wenzel <mairaw@microsoft.com>
* 12). Add topic files 23 to 26

* small edits

* small edits

* add missing description

* small edits

Co-authored-by: Maira Wenzel <mairaw@microsoft.com>
* 13). Add topic files 27 to 30

* readd hyphen

* add description

* small fixes

* minor edits

Co-authored-by: Maira Wenzel <mairaw@microsoft.com>
@BillWagner BillWagner modified the milestones: February 2020, March 2020 Mar 3, 2020
@mairaw mairaw closed this Mar 11, 2020
@mairaw mairaw reopened this Mar 11, 2020
@mairaw
Copy link
Contributor Author

mairaw commented Sep 1, 2020

I'm leaving this as ready for review. The only warnings are about some missing descriptions. Perhaps they were added to the current version of the files now. @jameshkramer not sure if you have one more cycle to spare and copy/add the missing descriptions?

@Youssef1313
Copy link
Member

Note: At some point these will need to move to the new fundamentals section. Doing that later will result in double redirection.

Pinging @BillWagner to confirm if this LINQ section is in the plan for the fundamentals sections.

@jameshkramer
Copy link
Contributor

@mairaw, yes, I'll fix these.

Jim

@mairaw
Copy link
Contributor Author

mairaw commented Sep 2, 2020

LINQ is certainly fundamental content. If there's a better location for this @BillWagner, please let us know. I agree that it would be easier not have to move this content twice. But also merge conflicts are getting complicated, so I'd like to merge this content soon.

@mairaw mairaw closed this Sep 3, 2020
@mairaw mairaw reopened this Sep 3, 2020
@BillWagner
Copy link
Member

In time, this will end up in "fundamentals". That said, I agree with @mairaw that this is a huge improvement, and the longer we wait the more merge conflicts we'll have with this PR.

Let's :shipit: as soon as the merge conflicts are fixed (again). I've approved it @mairaw

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, and let's merge it as soon as the conflicts are resolved..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants