Desktop e-book: Chapter 1 #17299
Merged
Desktop e-book: Chapter 1 #17299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mairaw
added
📖 guide - Modernizing Desktop apps
and removed
📚 Area - Desktop Guide
labels
|
@OliaG one thing that would help a lot with the review is to make sure that we ran Acrolinx on the new articles. Installation docs: https://review.docs.microsoft.com/en-us/help/contribute/contribute-get-started-setup-acrolinx-vscode?branch=master Our minimum score to merge should be 80. Here's the Acrolinx report for this article: https://microsoft-ce-csi.acrolinx.cloud/api/v1/checking/scorecards/12be85a1-78d9-47ae-b5ed-4c14842c24cf (there are false positives as well; when you use the VS Code extension, you can ignore the ones that are not applicable) |
mairaw
reviewed
Mar 3, 2020
docs/architecture/modernize-desktop/why-modern-desktop-applications.md
Outdated
Show resolved
Hide resolved
…tions.md Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>
mairaw
reviewed
Mar 12, 2020
docs/architecture/modernize-desktop/why-modern-desktop-applications.md
Outdated
Show resolved
Hide resolved
docs/architecture/modernize-desktop/why-modern-desktop-applications.md
Outdated
Show resolved
Hide resolved
docs/architecture/modernize-desktop/why-modern-desktop-applications.md
Outdated
Show resolved
Hide resolved
docs/architecture/modernize-desktop/why-modern-desktop-applications.md
Outdated
Show resolved
Hide resolved
docs/architecture/modernize-desktop/why-modern-desktop-applications.md
Outdated
Show resolved
Hide resolved
docs/architecture/modernize-desktop/why-modern-desktop-applications.md
Outdated
Show resolved
Hide resolved
docs/architecture/modernize-desktop/why-modern-desktop-applications.md
Outdated
Show resolved
Hide resolved
docs/architecture/modernize-desktop/why-modern-desktop-applications.md
Outdated
Show resolved
Hide resolved
docs/architecture/modernize-desktop/why-modern-desktop-applications.md
Outdated
Show resolved
Hide resolved
docs/architecture/modernize-desktop/why-modern-desktop-applications.md
Outdated
Show resolved
Hide resolved
Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>
|
@mairaw thank you very much for the review! ❤ All comments are addressed. |
mairaw
reviewed
Apr 3, 2020
docs/architecture/modernize-desktop/why-modern-desktop-applications.md
Outdated
Show resolved
Hide resolved
docs/architecture/modernize-desktop/why-modern-desktop-applications.md
Outdated
Show resolved
Hide resolved
docs/architecture/modernize-desktop/why-modern-desktop-applications.md
Outdated
Show resolved
Hide resolved
docs/architecture/modernize-desktop/why-modern-desktop-applications.md
Outdated
Show resolved
Hide resolved
Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>
|
@mairaw All comments are addressed |
mairaw
added a commit
that referenced
this pull request
Apr 14, 2020
* Add chapter 1 * Update docs/architecture/modernize-desktop/why-modern-desktop-applications.md Co-Authored-By: Maira Wenzel <mairaw@microsoft.com> * Updated to 85 Acrolinx score * Apply suggestions from code review Co-Authored-By: Maira Wenzel <mairaw@microsoft.com> * Address comments and added Next button * Apply suggestions from code review Co-Authored-By: Maira Wenzel <mairaw@microsoft.com> * Removed question mark from the title Co-authored-by: Maira Wenzel <mairaw@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the content of chapter 1. The difference to the existing PR is that this is opened using a branch from upstream, i.e. dotnet/docs rather than my fork. Let's see whether this fixes the CI...