-
Couldn't load subscription status.
- Fork 6.1k
Desktop e-book: Chapter 2 #17300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Desktop e-book: Chapter 2 #17300
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments...
docs/architecture/modernize-desktop/whats-new-dotnet-core-desktop.md
Outdated
Show resolved
Hide resolved
docs/architecture/modernize-desktop/whats-new-dotnet-core-desktop.md
Outdated
Show resolved
Hide resolved
docs/architecture/modernize-desktop/whats-new-dotnet-core-desktop.md
Outdated
Show resolved
Hide resolved
docs/architecture/modernize-desktop/whats-new-dotnet-core-desktop.md
Outdated
Show resolved
Hide resolved
docs/architecture/modernize-desktop/whats-new-dotnet-core-desktop.md
Outdated
Show resolved
Hide resolved
docs/architecture/modernize-desktop/whats-new-dotnet-core-desktop.md
Outdated
Show resolved
Hide resolved
docs/architecture/modernize-desktop/whats-new-dotnet-core-desktop.md
Outdated
Show resolved
Hide resolved
docs/architecture/modernize-desktop/whats-new-dotnet-core-desktop.md
Outdated
Show resolved
Hide resolved
docs/architecture/modernize-desktop/whats-new-dotnet-core-desktop.md
Outdated
Show resolved
Hide resolved
docs/architecture/modernize-desktop/whats-new-dotnet-core-desktop.md
Outdated
Show resolved
Hide resolved
Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>
|
Addressed all the comments except for the picture, will fix the picture a bit later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few last comments and suggestions before we merge
Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>
|
@mairaw All comments are addressed. |
|
|
||
| This leads to reasoning about the API differences between verticals at the assembly level, as opposed to the individual API level that we had before. This aspect enabled a class library experience that can target multiple verticals, also known as portable class libraries. | ||
|
|
||
|  |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty hard to read this image plus wrong branding. .Net -> .NET
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except for the image problem
* Add chapter 2 * Update Acrolinx score to 85 * Apply suggestions from code review Co-Authored-By: Maira Wenzel <mairaw@microsoft.com> * Address Maira's comments * Remove trailing space * Add Previous and next buttons * Removed whitespace * Apply suggestions from code review Co-Authored-By: Maira Wenzel <mairaw@microsoft.com> Co-authored-by: Maira Wenzel <mairaw@microsoft.com>
This adds chapter 2 of the desktop ebook