Skip to content

Conversation

@OliaG
Copy link
Contributor

@OliaG OliaG commented Mar 3, 2020

This adds chapter 2 of the desktop ebook

Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments...

OliaG and others added 2 commits March 26, 2020 15:58
Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>
@OliaG
Copy link
Contributor Author

OliaG commented Mar 27, 2020

Addressed all the comments except for the picture, will fix the picture a bit later.

@BillWagner BillWagner modified the milestones: March 2020, April 2020 Apr 2, 2020
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few last comments and suggestions before we merge

Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>
@OliaG
Copy link
Contributor Author

OliaG commented Apr 10, 2020

@mairaw All comments are addressed.


This leads to reasoning about the API differences between verticals at the assembly level, as opposed to the individual API level that we had before. This aspect enabled a class library experience that can target multiple verticals, also known as portable class libraries.

![Release history of .NET Framework](./media/whats-new-dotnet-core/release-history.png)
Copy link
Contributor

@mairaw mairaw Apr 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty hard to read this image plus wrong branding. .Net -> .NET

Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for the image problem

@mairaw mairaw merged commit 0c0c008 into desktop-ebook Apr 14, 2020
@mairaw mairaw deleted the chapter-2 branch April 14, 2020 01:26
mairaw added a commit that referenced this pull request Apr 14, 2020
* Add chapter 2

* Update Acrolinx score to 85

* Apply suggestions from code review

Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>

* Address Maira's comments

* Remove trailing space

* Add Previous and next buttons

* Removed whitespace

* Apply suggestions from code review

Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>

Co-authored-by: Maira Wenzel <mairaw@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants