Skip to content

Desktop e-book: Chapter 5 #17303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: Desktop e-book
merged 14 commits into from
May 13, 2020
Merged

Desktop e-book: Chapter 5 #17303

merged 14 commits into from
May 13, 2020

Conversation

@OliaG
Copy link
Contributor

@OliaG OliaG commented Mar 3, 2020

This supersedes #17259, with the difference that I'm issuing the PR from a branch in dotnet/docs, rather than my fork.

@OliaG OliaG requested review from mairaw and nishanil March 3, 2020 03:59
@dotnet-bot dotnet-bot added this to the March 2020 milestone Mar 3, 2020
@mairaw mairaw requested a review from Thraka March 3, 2020 08:02
@BillWagner BillWagner modified the milestones: March 2020, April 2020 Apr 2, 2020
mairaw
mairaw reviewed Apr 23, 2020
View reviewed changes
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First set of review comments

mairaw
mairaw reviewed Apr 27, 2020
View reviewed changes
mairaw
mairaw reviewed Apr 27, 2020
View reviewed changes
mairaw
mairaw reviewed Apr 27, 2020
View reviewed changes
OliaG and others added 4 commits April 28, 2020 11:07
@OliaG @mairaw
Apply suggestions from code review
3ecf58a 
Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>
Address Maira's comments
6eb37de
rename file
30ae1a4
Revert "rename file"
ee064d6 
This reverts commit 30ae1a4.
@BillWagner BillWagner modified the milestones: April 2020, May 2020 Apr 28, 2020
mairaw
mairaw reviewed Apr 30, 2020
View reviewed changes
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more comments...

@OliaG @mairaw
Apply suggestions from code review
93e0bf8 
Co-authored-by: Maira Wenzel <mairaw@microsoft.com>
@OliaG
Copy link
Contributor Author

OliaG commented May 11, 2020

Addressed all comments. Not sure why markdown is failing, I haven't introduced any markdown errors.

@mairaw
Copy link
Contributor

mairaw commented May 13, 2020

Don't worry about those

mairaw
mairaw approved these changes May 13, 2020
View reviewed changes
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mairaw mairaw merged commit 3697f2f into desktop-ebook May 13, 2020
@mairaw mairaw deleted the chapter-5 branch May 13, 2020 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mairaw mairaw mairaw approved these changes

@nishanil nishanil Awaiting requested review from nishanil

@Thraka Thraka Awaiting requested review from Thraka

Assignees

No one assigned

Labels

dotnet-architecture/svc

Projects

None yet

Milestone

May 2020

Development

Successfully merging this pull request may close these issues.

4 participants

@OliaG @mairaw @BillWagner @dotnet-bot