Skip to content

Desktop e-book: Chapter 6 #17305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: Desktop e-book
merged 14 commits into from
May 13, 2020
Merged

Desktop e-book: Chapter 6 #17305

merged 14 commits into from
May 13, 2020

Conversation

@OliaG
Copy link
Contributor

@OliaG OliaG commented Mar 3, 2020

This supersedes #17260, with the difference that I'm issuing the PR from a branch in dotnet/docs, rather than my fork.

@OliaG OliaG requested review from mairaw and nishanil March 3, 2020 04:00
@dotnet-bot dotnet-bot added this to the March 2020 milestone Mar 3, 2020
@mairaw mairaw requested a review from Thraka March 3, 2020 08:02
@BillWagner BillWagner modified the milestones: March 2020, April 2020 Apr 2, 2020
mairaw
mairaw reviewed Apr 27, 2020
View reviewed changes
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First set of comments. I'll continue later.

mairaw
mairaw reviewed Apr 28, 2020
View reviewed changes
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More comments...

@OliaG @mairaw
Apply suggestions from code review
a4b1d9f 
Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>
@BillWagner BillWagner modified the milestones: April 2020, May 2020 Apr 28, 2020
mairaw
mairaw reviewed May 1, 2020
View reviewed changes
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More comments...

OliaG and others added 2 commits May 11, 2020 09:08
@OliaG @mairaw
Apply suggestions from code review
3bb474d 
Co-authored-by: Maira Wenzel <mairaw@microsoft.com>
Address review comments
4cc5d04
@OliaG
Copy link
Contributor Author

OliaG commented May 11, 2020

Addressed all comments. Not sure why markdown is failing, I haven't introduced any markdown errors.

mairaw
mairaw approved these changes May 13, 2020
View reviewed changes
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll merge as soon as builds are green.

@mairaw mairaw merged commit ca86b0c into desktop-ebook May 13, 2020
@mairaw mairaw deleted the chapter-6 branch May 13, 2020 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mairaw mairaw mairaw approved these changes

@nishanil nishanil Awaiting requested review from nishanil

@Thraka Thraka Awaiting requested review from Thraka

Assignees

No one assigned

Labels

dotnet-architecture/svc

Projects

None yet

Milestone

May 2020

Development

Successfully merging this pull request may close these issues.

4 participants

@OliaG @mairaw @BillWagner @dotnet-bot