-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Replace redirects - C# and VB #17899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BillWagner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this is great @gewarren
I had one comment. Is there a way to tag those redirects that are by design?
| To create an intermediate .winmdobj file. | ||
|
|
||
| Unless you specify **-target:module**, **-target** causes a .NET Framework assembly manifest to be placed in an output file. For more information, see [Assemblies in .NET](../../../standard/assembly/index.md) and [Common Attributes](../../programming-guide/concepts/attributes/common-attributes.md). | ||
| Unless you specify **-target:module**, **-target** causes a .NET Framework assembly manifest to be placed in an output file. For more information, see [Assemblies in .NET](../../../standard/assembly/index.md) and [Common Attributes](../attributes/global.md). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this. I thought I had found all these links when I updated the related articles.
docs/csharp/misc/cs0612.md
Outdated
| 'member' is obsolete | ||
|
|
||
| The class designer marked a member with the [Obsolete](../programming-guide/concepts/attributes/common-attributes.md#Obsolete) attribute. This means that the member might not be supported in a future version of the class. | ||
| The class designer marked a member with the <xref:System.ObsoleteAttribute> attribute. This means that the member might not be supported in a future version of the class. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is now targeting a different article, but I think that's fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't find a mention of Obsolete in common-attributes.md. Let me know if I just missed it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-Authored-By: Bill Wagner <wiwagn@microsoft.com>
|
@BillWagner Could you merge this one? The WIP check is acting up. |
No description provided.