Skip to content

Conversation

@gewarren
Copy link
Contributor

No description provided.

@dotnet-bot dotnet-bot added this to the April 2020 milestone Apr 17, 2020
@gewarren gewarren changed the title Replace redirects Replace redirects - C# and VB Apr 17, 2020
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this is great @gewarren

I had one comment. Is there a way to tag those redirects that are by design?

To create an intermediate .winmdobj file.

Unless you specify **-target:module**, **-target** causes a .NET Framework assembly manifest to be placed in an output file. For more information, see [Assemblies in .NET](../../../standard/assembly/index.md) and [Common Attributes](../../programming-guide/concepts/attributes/common-attributes.md).
Unless you specify **-target:module**, **-target** causes a .NET Framework assembly manifest to be placed in an output file. For more information, see [Assemblies in .NET](../../../standard/assembly/index.md) and [Common Attributes](../attributes/global.md).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this. I thought I had found all these links when I updated the related articles.

'member' is obsolete

The class designer marked a member with the [Obsolete](../programming-guide/concepts/attributes/common-attributes.md#Obsolete) attribute. This means that the member might not be supported in a future version of the class.
The class designer marked a member with the <xref:System.ObsoleteAttribute> attribute. This means that the member might not be supported in a future version of the class.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now targeting a different article, but I think that's fine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't find a mention of Obsolete in common-attributes.md. Let me know if I just missed it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gewarren gewarren changed the title Replace redirects - C# and VB WIP Replace redirects - C# and VB Apr 17, 2020
@gewarren gewarren changed the title WIP Replace redirects - C# and VB Replace redirects - C# and VB Apr 17, 2020
@gewarren
Copy link
Contributor Author

@BillWagner Could you merge this one? The WIP check is acting up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants