Skip to content

Rework some GC content #17997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 22, 2020
Merged

Rework some GC content #17997

merged 6 commits into from
Apr 22, 2020

Conversation

@gewarren
Copy link
Contributor

@gewarren gewarren commented Apr 21, 2020 •
edited
Loading

  • Combine info from orphaned gc.md file into fundamentals.md.
  • Split out fundamentals article into workstation/server and background GC articles.

Contributes to #17918.

@gewarren gewarren requested review from a team and BillWagner as code owners April 21, 2020 22:35
@dotnet-bot dotnet-bot added this to the April 2020 milestone Apr 21, 2020
BillWagner
BillWagner approved these changes Apr 22, 2020
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great work @gewarren

I had a couple thoughts regarding titles. You can accept them if you like.

Then, go ahead and :shipit:

@gewarren @BillWagner
Apply suggestions from Bill
3f544d1 
Co-Authored-By: Bill Wagner <wiwagn@microsoft.com>
@gewarren gewarren merged commit adfdafb into dotnet:master Apr 22, 2020
@gewarren gewarren deleted the orphan-gc branch April 22, 2020 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BillWagner BillWagner BillWagner approved these changes

Assignees

No one assigned

Labels

dotnet-csharp/svc fundamentals/subsvc

Projects

None yet

Milestone

April 2020

Development

Successfully merging this pull request may close these issues.

3 participants

@gewarren @BillWagner @dotnet-bot