Restructure and modernize tour of C# #18538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillWagner
force-pushed
the
program-structure-tour
branch
2 times, most recently
from
cf5f052 to
04a27c4
Compare
BillWagner
force-pushed
the
program-structure-tour
branch
from
04a27c4 to
d2de5e3
Compare
BillWagner
force-pushed
the
program-structure-tour
branch
3 times, most recently
from
c5159cf to
399e6ca
Compare
BillWagner
force-pushed
the
program-structure-tour
branch
from
ce617a2 to
a0297c9
Compare
BillWagner
force-pushed
the
program-structure-tour
branch
from
52ba4a2 to
65ebbaa
Compare
BillWagner
force-pushed
the
program-structure-tour
branch
from
65ebbaa to
d111614
Compare
BillWagner
force-pushed
the
program-structure-tour
branch
2 times, most recently
from
20400b9 to
b933abd
Compare
BillWagner
force-pushed
the
program-structure-tour
branch
from
b933abd to
f9181bb
Compare
BillWagner
force-pushed
the
program-structure-tour
branch
from
69dcdd5 to
89b794b
Compare
pkulikov
reviewed
Aug 7, 2020
pkulikov
reviewed
Aug 7, 2020
pkulikov
reviewed
Aug 7, 2020
pkulikov
reviewed
Aug 7, 2020
pkulikov
reviewed
Aug 7, 2020
Co-authored-by: Petr Kulikov <petr.kulikov@gmail.com>
…r/docs into program-structure-tour
IEvangelist
approved these changes
Aug 7, 2020
Member
There was a problem hiding this comment.
Hi @BillWagner - This was a ton of work, great job! It's so much better with your improvements. I left a lot of nit comments and some code suggestions. It's up to you if you want to take them or not. There were some typos and grammatical suggestions in there too. And even several questions!
Looks good to me, 
when you're ready.
tdykstra
approved these changes
Aug 8, 2020
Contributor
tdykstra
left a comment
tdykstra
left a comment
There was a problem hiding this comment.
This is great work, clearly written and comprehensive! I had mostly minor typo comments but also noted one misplaced snippet.
docs/csharp/tour-of-csharp/types.md
Outdated
|
|
||
| ## Nullable types | ||
|
|
||
| Variables of any type may be declared as ***non-nullable*** or ***nullable***. A nullable variable can hold an additional `null` value, indicating no value. Nullable Value types (structs or enums) are represented by <xref:System.Nullable%601?displayProperty=nameWithType>. Non-nullable and Nullable Reference types are both represented by the underlying reference type. The distinction is represented by metadata read by the compiler and some libraries. The compiler provides warnings when nullable references are de-referenced without first checking their value against `null`. The compiler also provides warnings when non-nullable references are assigned to a value that may be `null`. The following example declares a ***nullable int***, initializing it to `null`. Then, it sets the value to `5`. It demonstrates the same concept with a ***nullable string***. For more information, see [nullable value types](language-reference/builtin-types/nullable-value-types.md) and [nullable reference types](../nullable-references.md). |
Contributor
There was a problem hiding this comment.
can hold an additional null value
"additional" to what?
Co-authored-by: Tom Dykstra <tdykstra@microsoft.com> Co-authored-by: David Pine <david.pine@microsoft.com>
And fix build warnings that crept in.
BillWagner
added
dotnet-csharp/svc
get-started/subsvc
and removed
📚 Area - C# Guide
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9576
Fixes #13640
Fixes #16176
Fixes #18182
Fixes #18672
The Tour of C# has become very dated.
In this PR, I reviewed and updated each section:
cscInternal review link