Skip to content

Update dotnet-dump docs #19696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
IEvangelist merged 2 commits into from
Aug 28, 2020
Merged

Update dotnet-dump docs #19696

IEvangelist merged 2 commits into from
Aug 28, 2020

Conversation

@Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Jul 26, 2020 •
edited
Loading

No description provided.

@Youssef1313 Youssef1313 requested review from a team and sdmaclea as code owners July 26, 2020 17:47
@dotnet-bot dotnet-bot added this to the July 2020 milestone Jul 26, 2020
@Youssef1313 Youssef1313 changed the title Add see also section for gcdump Update dotnet-dump docs Jul 28, 2020
@Youssef1313 Youssef1313 marked this pull request as draft July 28, 2020 06:56
Youssef1313
Youssef1313 commented Jul 28, 2020
View reviewed changes
@Youssef1313 Youssef1313 marked this pull request as ready for review July 28, 2020 07:08
sdmaclea
sdmaclea reviewed Jul 31, 2020
View reviewed changes
Copy link
Contributor

@sdmaclea sdmaclea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tdykstra
tdykstra approved these changes Jul 31, 2020
View reviewed changes
Copy link
Contributor

@tdykstra tdykstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Youssef1313 !

@IEvangelist IEvangelist merged commit 4705e59 into dotnet:master Aug 28, 2020
@Youssef1313 Youssef1313 deleted the patch-19 branch August 28, 2020 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tdykstra tdykstra tdykstra approved these changes

+1 more reviewer

@sdmaclea sdmaclea sdmaclea left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

July 2020

Development

Successfully merging this pull request may close these issues.

6 participants

@Youssef1313 @tdykstra @sdmaclea @BillWagner @IEvangelist @dotnet-bot