Skip to content

Conversation

@maryamariyan
Copy link
Contributor

@maryamariyan maryamariyan commented Oct 21, 2020

Summary

@shirhatti @Rick-Anderson
As the first draft could you please help me check:

  • which items are over explained and if there is anything I missed that needs to be covered?
  • next if the order of issues discussed are good?
  • If the samples need to fundamentally change?

Next please let me know if I need to use other ways to share source code, perhaps:

  • use link to gist instead?

Then we can go through the proper wording and I will fixup the wordings once the big issues are addressed.

Fixes dotnet/AspNetCore.Docs#19224

PS edit by @Rick-Anderson
Internal review URL

@maryamariyan maryamariyan requested a review from a team as a code owner October 21, 2020 22:57
@dotnet-bot dotnet-bot added this to the October 2020 milestone Oct 21, 2020
@Rick-Anderson
Copy link
Contributor

Rick-Anderson commented Oct 21, 2020

@maryamariyan this looks fantastic

@IEvangelist would it be possible for you to:

  • create a new branch off this that merges into this branch. Alternatively, create a new branch that brings these commits over and merges into master.
  • migrate code in snippets
  • replace all occurrences of simple with basic (per style guide) - Edit: arg, looks like you can't, it's unfortunately baked into the API. MT is going to be a challenge, might need to exclude simple.
  • Add this to the TOC
  • Obviously apply style guide, eg, the above, to the preceding

@maryamariyan has done all the hard work, it just needs some editorial polish.

@IEvangelist
Copy link
Member

@maryamariyan Maryam Ariyan FTE this looks fantastic

@IEvangelist David Pine FTE would it be possible for you to:

  • create a new branch off this that merges into this branch. Alternatively, create a new branch that brings these commits over and merges into master.
  • migrate code in snippets
  • replace all occurrences of simple with basic (per style guide) - Edit: arg, looks like you can't, it's unfortunately baked into the API. MT is going to be a challenge, might need to exclude simple.
  • Add this to the TOC
  • Obviously apply style guide, eg, the above, to the preceding

@maryamariyan Maryam Ariyan FTE has done all the hard work, it just needs some editorial polish.

I'll take it from here, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New docs for Log Formatter APIs

6 participants