Add clarifying examples of possible errant conditions #21200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gewarren
reviewed
Oct 26, 2020
BillWagner
approved these changes
Oct 26, 2020
There was a problem hiding this comment.
This LGTM @IEvangelist
I did have one comment to add a bit of clarifying text, and then this is ready to 
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add clarifying examples of possible errant conditions, and acceptable patterns.
Fixes #21134
Preview
✔️ Implement a
DisposeAsyncmethod