Skip to content

Conversation

@jmarolf
Copy link
Contributor

@jmarolf jmarolf commented Oct 28, 2020

Summary

Calls out that enforcing code style on build is experimental

@jmarolf jmarolf requested a review from gewarren as a code owner October 28, 2020 23:19
@dotnet-bot dotnet-bot added this to the October 2020 milestone Oct 28, 2020
@jmarolf
Copy link
Contributor Author

jmarolf commented Oct 28, 2020

CC: @mavasani @mikadumont

Copy link
Contributor

@mikadumont mikadumont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the proper doc syntax for notes is the following:

[!NOTE] This feature is currently experimental and may change between the .NET 5 and .NET 6 releases.

@mavasani
Copy link
Contributor

@jmarolf Do you plan to do a follow-up PR for mentioning the new property page for enforcing code style on build (or will that need to go into VS docs repo)? Eventually, once we release Microsoft.CodeAnalysis.NetAnalyzers 5.0.0 NuGet package post .NET 5.0 GA, we should also mention the NuGet package here as an alternative.

@jmarolf
Copy link
Contributor Author

jmarolf commented Oct 29, 2020

@mavasani good idea, I'll submit a PR to the VS docs repo after this

@jmarolf jmarolf merged commit d343cd5 into master Oct 29, 2020
@jmarolf jmarolf deleted the dev/jmarolf/code-style-wording branch October 29, 2020 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants