Null-forgiving and null-conditional interaction is fixed #21531
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillWagner
approved these changes
Nov 23, 2020
There was a problem hiding this comment.
Thanks @pkulikov
I apologize for missing this earlier. It looks great, and I'll 
now.
BillWagner
added
dotnet-csharp/svc
lang-reference/subsvc
and removed
📚 Area - C# Guide
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the continuation of #17988
That "unexpected behavior" was fixed in dotnet/roslyn#47712. As far as I understand from my tests, that compiler change also has an effect for the C# 8.0 code (at least, the code in #17988 (comment) doesn't throw anymore for C# 8.0). So, the current note text is not correct anymore.
This PR suggests the most radical fix that is according to the latest compiler. There are some alternatives, though, if we want to keep documenting previous compiler versions.
From the referenced PR, I assume that that compiler change has been shipped with the compiler in Visual Studio 16.8. That means that alternative wording of the note would be:
I don't like it, as Visual Studio is not the only available editor. Another option is to mention .NET Core SDK version.
@BillWagner what do you think?