Skip to content

Conversation

@ericmutta
Copy link
Contributor

The following sentence:

For types that are immutable because all their property setters are non-public, see the following section about non-public property accessors.

...references and links to the section titled Non-public property accessors but that section is literally one line below the above sentence, so the link is not really required (clicking the link makes the browser scroll just a few pixels down). I have removed the link and edited the sentence accordingly.

The following sentence:

> For types that are immutable because all their property setters are non-public, see the following section about **non-public property accessors**.

...references and links to the section titled **Non-public property accessors** but that section is literally one line below the above sentence, so the link is not really required (clicking the link makes the browser scroll just a few pixels down). I have edited the sentence accordingly.
Copy link
Contributor

@tdykstra tdykstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ericmutta -- I have one suggestion.

Co-authored-by: Tom Dykstra <tdykstra@microsoft.com>
Copy link
Contributor

@tdykstra tdykstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that worked, thanks!

@ericmutta
Copy link
Contributor Author

ericmutta commented Feb 26, 2021

Awesome! Many thanks to you (and the team) for your efforts on documenting System.Text.Json so thoroughly! It has been a pleasure reading through it all and a privilege to be able to contribute some minor fixes 🙏

@tdykstra
Copy link
Contributor

tdykstra commented Mar 3, 2021

Closing and reopening to trigger build

@tdykstra tdykstra closed this Mar 3, 2021
@tdykstra tdykstra reopened this Mar 3, 2021
@tdykstra tdykstra merged commit 1403c3f into dotnet:master Mar 4, 2021
@ericmutta ericmutta deleted the patch-3 branch March 4, 2021 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants