Verbatim string interpolation guidance #29782
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeanKilleen
changed the title
SeanKilleen
commented
Jun 9, 2022
BillWagner
reviewed
Jun 9, 2022
Thanks Bill! Co-authored-by: Bill Wagner <wiwagn@microsoft.com>
Contributor
Author
|
OK, I think this is all good now. 👍 Ready for official review. |
BillWagner
requested changes
Jun 9, 2022
Member
BillWagner
left a comment
BillWagner
left a comment
There was a problem hiding this comment.
Hi @SeanKilleen
I like what you've added.
Right now, there is a mis-match between the code text and the output. That's because verbatim strings include all whitespace. This is important because we're adding raw string literals in C# 11. I've put in two different suggestions. Either one of them would work. I have a mild preference for changing the displayed output, but either is fine.
docs/csharp/programming-guide/strings/snippets/VerbatimStringInterpolation.cs
Outdated
Show resolved
Hide resolved
docs/csharp/programming-guide/strings/snippets/VerbatimStringInterpolation.cs
Show resolved
Hide resolved
…nterpolation.cs This makes the most sense to me. Co-authored-by: Bill Wagner <wiwagn@microsoft.com>
Contributor
Author
|
Thanks @BillWagner! I agree with your suggestion to change the output, and I committed it. 👍 |
BillWagner
approved these changes
Jun 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #29765.