Fix HttpClient .NET Framework guidance #31220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IEvangelist
approved these changes
Sep 16, 2022
Member
IEvangelist
left a comment
IEvangelist
left a comment
There was a problem hiding this comment.
Looks good to me, we'll 
, but first I'd like to make sure that @gewarren has a chance to see these changes too - thank you 🙏
gewarren
reviewed
Sep 16, 2022
Contributor
gewarren
left a comment
gewarren
left a comment
There was a problem hiding this comment.
Thanks for updating this @CarnaViire!
|
What's the detriment to using a long-lived HttpClient on .NET Framework? The docs doesn't say anything about that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes wrong guidance for HttpClient on .NET Framework, that could lead to socket exhaustion
Fixes #31187
Fixes #30511
Fixes #30635