Skip to content

Specify where to actually set assembly attributes #33552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 17, 2023
Merged

Specify where to actually set assembly attributes #33552

merged 2 commits into from
Jan 17, 2023

Conversation

@olfek
Copy link
Contributor

@olfek olfek commented Jan 16, 2023

"Set assembly attributes" page ironically doesn't say where to set assembly attributes. Ha.

@olfek
Specify where to actually set assembly attributes
16ed367 
"Set assembly attributes" page ironically doesn't say where to set assembly attributes. Ha.
@olfek olfek requested a review from IEvangelist as a code owner January 16, 2023 16:04
@ghost ghost added the community-contribution Indicates PR is created by someone from the .NET community. label Jan 16, 2023
IEvangelist
IEvangelist approved these changes Jan 17, 2023
View reviewed changes
Copy link
Member

@IEvangelist IEvangelist left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this proposal, thanks for adding this. I have a nit about the text and the file reference. Files should be italicized, otherwise, this is great.

@olfek @IEvangelist
Suggestion by @IEvangelist
97196a1 
Co-authored-by: David Pine <david.pine@microsoft.com>
@IEvangelist IEvangelist enabled auto-merge (squash) January 17, 2023 20:00
@IEvangelist IEvangelist merged commit fbb3636 into dotnet:main Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IEvangelist IEvangelist IEvangelist approved these changes

Assignees

No one assigned

Labels

community-contribution Indicates PR is created by someone from the .NET community.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@olfek @IEvangelist