Update trimming doc #36487
Merged
Update trimming doc #36487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitek-karas
reviewed
Aug 2, 2023
sbomer
reviewed
Aug 2, 2023
Contributor
Author
|
@sbomer @vitek-karas sorry this has taken so long, I'm doing it after I get my ASP.NET Core work completed. Can you review the changes? If there are extensive changes that still need to be made I'll schedule a meeting so we can finish the doc. |
sbomer
reviewed
Aug 23, 2023
Co-authored-by: Sven Boemer <sbomer@gmail.com>
vitek-karas
reviewed
Aug 24, 2023
vitek-karas
reviewed
Aug 24, 2023
vitek-karas
reviewed
Aug 24, 2023
docs/core/deploying/trimming/snippets/ConsoleApp1/ConsoleApp1.csproj
Outdated
Show resolved
Hide resolved
vitek-karas
reviewed
Aug 24, 2023
docs/core/deploying/trimming/snippets/ConsoleApp1/ConsoleApp1.csproj
Outdated
Show resolved
Hide resolved
vitek-karas
reviewed
Aug 24, 2023
vitek-karas
reviewed
Aug 24, 2023
vitek-karas
reviewed
Aug 24, 2023
vitek-karas
reviewed
Aug 24, 2023
vitek-karas
reviewed
Aug 24, 2023
vitek-karas
approved these changes
Aug 24, 2023
Member
vitek-karas
left a comment
vitek-karas
left a comment
There was a problem hiding this comment.
Mostly typos and other nits - overall it's a great improvement, thanks a lot!
Co-authored-by: Vitek Karas <10670590+vitek-karas@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36518
Internal previews