Update samples #38401
Merged
Update samples #38401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
embrace NRT
embrace NRT
Update GetConnectionStringByName
Update GetConnectionStringByProvider
DataWorks DataSet.Merge has a DataSet.ReadXml overload warning but all projects should compile and comply with Bill's CI gates
Run snippets 5000 for PR https://github.com/dotnet/docs/actions/runs/6934430988/job/18862504635?pr=36663#step:6:1389 😭 Compile targets with unresolved issues: D:\a\docs\docs\samples\snippets\csharp\VS_Snippets_ADO.NET\DP LINQ to DataSet Examples\CS\LINQtoDataSetExamplesCS.csproj D:\a\docs\docs\samples\snippets\csharp\VS_Snippets_ADO.NET\DataWorks SqlClient.CAS\CS\Project.csproj D:\a\docs\docs\samples\snippets\csharp\VS_Snippets_ADO.NET\DataWorks SqlDependency.AspNet\CS\Project.csproj so I deleted those 3 projects [that I had unloaded locally in my VS, but files still in PR to break CI] - well, still contributing 50+ projects, so Bill/David can fix those 3 (or retire them) you probably still won't like DataWorks DataSet.Merge with CA5366 but you can nuke that too if bothersome - BTW "allow edits by maintainers" has always been checked Otherwise I'm happy with Bill's commits yesterday, so you have the wheel to drive this over the line!
Run dotnet/docs-tools/actions/status-checker@main so I've dropped that project too (leaving 4 to your senior magic) - hope this gives a clear round with remaining 53 projs
…iously unloaded so SYSLIB0003 coughed on 'SqlClientPermission' is obsolete: 'Code Access Security is not supported or honored by the runtime.' 'PermissionState' is obsolete: 'Code Access Security is not supported or honored by the runtime.' hence have nuked that project too [bummer] and trying again
…had previously unloaded so SYSLIB0003 coughed on" This reverts commit fa5bc35.
This reverts commit 288a27a.
This reverts commit 57f39ed.
BillWagner
force-pushed
the
fix-pr-36663
branch
from
1c9e871 to
98eeee1
Compare
|
yup, happy that YOU reinvented #38401 with bunch of WinForms .NET4.8 etc stuff [that I'd mostly forgotten] to supercede #36663. Seems that #38401 is still chewing on "Run dotnet/docs-tools/actions/status-checker@main" for 2hrs 43min as I write this, but hopefully will eventually resolve successfully to improve the ADO.NET story. Fair warning I'm looking at LINQ next ! |
IEvangelist
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supercedes #36663
Pulling those changes into a new branch to fix the build issues.