Skip to content

change the type of the 'Version' property to string #49114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 14, 2025
Merged

change the type of the 'Version' property to string #49114

merged 1 commit into from
Oct 14, 2025
+10 −10

Conversation

StuartMosquera
Copy link
Contributor

@StuartMosquera StuartMosquera commented Oct 13, 2025 •
edited by github-actions bot
Loading

Summary

  • This PR changes the type of the 'Version' property for the attribute from double to string.

Fixes #49113

Internal previews

📄 File 🔗 Preview link
docs/csharp/advanced-topics/reflection-and-attributes/creating-custom-attributes.md docs/csharp/advanced-topics/reflection-and-attributes/creating-custom-attributes

@StuartMosquera StuartMosquera requested review from a team and BillWagner as code owners October 13, 2025 15:22
@dotnetrepoman dotnetrepoman bot added this to the October 2025 milestone Oct 13, 2025
@dotnet-policy-service dotnet-policy-service bot added dotnet-csharp/svc community-contribution Indicates PR is created by someone from the .NET community. labels Oct 13, 2025
@StuartMosquera StuartMosquera changed the title change the type of the 'Version' attribute to string change the type of the 'Version' property to string Oct 13, 2025
BillWagner
BillWagner approved these changes Oct 14, 2025
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @StuartMosquera

I'll :shipit: now.

@BillWagner BillWagner merged commit ae5f70f into dotnet:main Oct 14, 2025
8 checks passed
@StuartMosquera StuartMosquera deleted the change-attribute-type branch October 14, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BillWagner BillWagner BillWagner approved these changes

Assignees

No one assigned

Labels

community-contribution Indicates PR is created by someone from the .NET community. dotnet-csharp/svc

Projects

None yet

Milestone

October 2025

Development

Successfully merging this pull request may close these issues.

The Version attribute should be a string, not a double

2 participants

@StuartMosquera @BillWagner