Skip to content

Fix #49457 – Update VB build instructions to prefer dotnet build over vbc.exe #49518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Oct 30, 2025
Merged

Fix #49457 – Update VB build instructions to prefer dotnet build over vbc.exe #49518

merged 15 commits into from
Oct 30, 2025
+23 −8

Conversation

@veerasai06
Copy link
Contributor

@veerasai06 veerasai06 commented Oct 29, 2025 •
edited by github-actions bot
Loading

This PR updates the how-to-invoke-the-command-line-compiler.md article to reflect modern .NET build practices.

Changes made:

  • Added a tip note recommending the use of dotnet build for modern .NET projects.
  • Clarified that vbc.exe is only applicable for older .NET Framework projects.
  • Ensured formatting and examples remain consistent with other compiler docs.

Related issue:

Fixes #49457

Internal previews

📄 File 🔗 Preview link
docs/visual-basic/reference/command-line-compiler/how-to-invoke-the-command-line-compiler.md How to Invoke the Command-Line Compiler

@veerasai06 veerasai06 requested review from a team and BillWagner as code owners October 29, 2025 09:16
@dotnetrepoman dotnetrepoman bot added this to the October 2025 milestone Oct 29, 2025
@dotnet-policy-service dotnet-policy-service bot added dotnet-visualbasic/svc community-contribution Indicates PR is created by someone from the .NET community. labels Oct 29, 2025
@veerasai06
Copy link
Contributor Author

@dotnet-policy-service agree

@veerasai06
Copy link
Contributor Author

I fixed the broken “Conditional Compilation” link and verified all references.
The doc now correctly includes a link to dotnet build for modern .NET SDK usage.
This PR is ready for review.

@veerasai06
Copy link
Contributor Author

Hi @BillWagner, I’ve updated the Visual Basic compiler documentation as requested.
All checks have passed, and the PR includes modern .NET build usage notes.
Kindly review and approve when you get a chance. Thank you!

BillWagner
BillWagner reviewed Oct 30, 2025
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @veerasai06

This is great. I had a few small suggestions. Also, can you remove the fix-vb-docs-command file? It looks like it was checked in by accident.

@veerasai06
Copy link
Contributor Author

Hi @BillWagner,
I’ve removed the extra blank line and deleted the accidentally added fix-vb-docs-command file as suggested.
Please review when you get a chance. Thank you!

BillWagner
BillWagner approved these changes Oct 30, 2025
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @veerasai06

This looks great now. I'll :shipit: now. You should see the changes on our live site on the next day or two, on our regular publishing cycle.

@BillWagner BillWagner merged commit 47867f7 into dotnet:main Oct 30, 2025
9 checks passed
Copilot AI mentioned this pull request Oct 30, 2025
Merged
Copilot AI added a commit that referenced this pull request Oct 30, 2025
@adegeo
Fix errors from PR #49518: delete empty file, move TIP note, fix list…
bd9c9bd 
… numbering

Co-authored-by: adegeo <67293991+adegeo@users.noreply.github.com>
@veerasai06
Copy link
Contributor Author

Thank you @BillWagner for the review and merge!
I appreciate your feedback throughout this PR.
Glad to contribute to improving the Visual Basic docs — looking forward to more contributions!

BillWagner pushed a commit that referenced this pull request Oct 30, 2025
@adegeo
Fix errors in PR #49518: remove empty file, relocate TIP note, standa…
5aad86d 
…rdize list numbering (#49546)

* Initial plan

* Fix errors from PR #49518: delete empty file, move TIP note, fix list numbering

Co-authored-by: adegeo <67293991+adegeo@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: adegeo <67293991+adegeo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BillWagner BillWagner BillWagner approved these changes

Assignees

No one assigned

Labels

community-contribution Indicates PR is created by someone from the .NET community. dotnet-visualbasic/svc

Projects

None yet

Milestone

October 2025

Development

Successfully merging this pull request may close these issues.

Update VB Build instructions for modern .NET

2 participants

@veerasai06 @BillWagner