Skip to content

Conversation

@BillWagner
Copy link
Member

@BillWagner BillWagner commented Nov 10, 2025

Add existing diagnostics related to async and await.
Search the roslyn source for related error messages. Add them here.
Edit and consolidate this article.
@BillWagner BillWagner marked this pull request as ready for review November 10, 2025 23:08
@BillWagner BillWagner requested a review from a team as a code owner November 10, 2025 23:08
Copilot finished reviewing on behalf of BillWagner November 10, 2025 23:10
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR consolidates multiple async/await-related error and warning documentation files into a single comprehensive document. The goal is to organize 18 different compiler errors (CS1983-CS9330) related to async methods and await expressions into one centralized location with better categorization.

  • Consolidates 10 individual error files (CS1983, CS1986, CS1994, CS1996, CS1997, CS4008, CS4009, CS4014, CS4032, CS4033) into a new unified document
  • Organizes errors into three logical sections: await expression requirements, async method signature requirements, and async practices
  • Updates TOC, redirections, error lists, and internal documentation to reflect the consolidation

Reviewed Changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
async-await-errors.md New consolidated documentation covering 18 async/await errors organized into three categories
toc.yml Adds new async errors section and removes individual error entries, consolidating them into one navigation item
sorry-we-don-t-have-specifics-on-this-csharp-error.md Removes consolidated error codes from the "undocumented" list and adds blank line before C# 14 section
async.md Updates link from individual CS4014 page to consolidated async-await-errors page
.openpublishing.redirection.csharp.json Adds 10 redirections from old individual error pages to new consolidated page
error-consolidation.md Updates prompt template to reference async/await errors instead of using statement errors
CS4009.md, cs4033.md, cs4032.md, cs4014.md, cs4008.md, cs1997.md, cs1996.md, cs1994.md, cs1986.md, cs1983.md Deletes individual error files that are now consolidated

Copy link
Contributor

@meaghanlewis meaghanlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BillWagner these changes LGTM with the exception of the feedback Copilot left in async-await-errors.md. The 3 latter comments seem like good feedback.

BillWagner and others added 2 commits November 11, 2025 09:22
…rrors.md

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@BillWagner BillWagner enabled auto-merge (squash) November 11, 2025 14:23
@BillWagner BillWagner merged commit b3f0558 into dotnet:main Nov 11, 2025
9 checks passed
@BillWagner BillWagner deleted the async-errors-warnings branch November 11, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants