Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions .github/prompts/error-consolidation.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ Overall steps:

We're going to work through a series of files consolidating errors and warnings.

- For the duration of this chat, all references to "destination file" refer to `attribute-usage-errors.md`.
- For the duration of this chat, all references to "the target theme" refer to errors and warnings related to declaring and using *attributes*.
- For the duration of this chat, all references to "destination file" refer to `explicit-interface-errors.md`.
- For the duration of this chat, all references to "the target theme" refer to errors and warnings related to members that explicitly implement an interface member.

The destination file already contains a skeleton for the final output.

Expand Down Expand Up @@ -66,3 +66,14 @@ Understand these instructions, then suggest a list of themes and the included er

Rework the highlighted section so the focus is on how to correct each error. This article doesn't need to explain the associated language feature. Instead, in each section, provide links to language reference or language specification material that explains the rules violated when these diagnostics appear. Add explanatory context after each correction (in parentheses with the error code). Provided brief reasons why each correction is needed. Use detailed, sentence-style explanations rather than brief imperative statements. For each recommendation put the affectived error codes in parentheses, and in **bold** style. Remove extensive examples.

## Verify error messages

For every line in this table, verify that the error message associated with this error code matches the verbatim text in CSharpResources.resx. You can find the mapping using ErrorCodes.cs:

1. Find that number as a constant in `ErrorCodes.cs`.
2. Locate the corresponding `data` element in CSharpResources.resx. The `name` atttribute should match the number of the constant.
3. Read the error message found in the `<value>` element that is a child of that `<data>` element.

<make your own hand edits>

Now, ensure every instance of an error message matches the text in the highlighted table.
76 changes: 76 additions & 0 deletions .openpublishing.redirection.csharp.json
Original file line number Diff line number Diff line change
Expand Up @@ -315,6 +315,18 @@
"source_path_from_root": "/docs/csharp/language-reference/compiler-messages/cs0034.md",
"redirect_url": "/dotnet/csharp/language-reference/compiler-messages/overload-resolution"
},
{
"source_path_from_root": "/docs/csharp/language-reference/compiler-messages/cs0071.md",
"redirect_url": "/dotnet/csharp/language-reference/compiler-messages/interface-implementation-errors"
},
{
"source_path_from_root": "/docs/csharp/language-reference/compiler-messages/cs0106.md",
"redirect_url": "/dotnet/csharp/language-reference/compiler-messages/interface-implementation-errors"
},
{
"source_path_from_root": "/docs/csharp/misc/cs0277.md",
"redirect_url": "/dotnet/csharp/language-reference/compiler-messages/interface-implementation-errors"
},
{
"source_path_from_root": "/docs/csharp/language-reference/compiler-messages/cs0178.md",
"redirect_url": "/dotnet/csharp/language-reference/compiler-messages/array-declaration-errors"
Expand Down Expand Up @@ -355,6 +367,22 @@
"source_path_from_root": "/docs/csharp/language-reference/compiler-messages/cs0650.md",
"redirect_url": "/dotnet/csharp/language-reference/compiler-messages/array-declaration-errors"
},
{
"source_path_from_root": "/docs/csharp/language-reference/compiler-messages/cs0686.md",
"redirect_url": "/dotnet/csharp/language-reference/compiler-messages/interface-implementation-errors"
},
{
"source_path_from_root": "/docs/csharp/misc/cs0736.md",
"redirect_url": "/dotnet/csharp/language-reference/compiler-messages/interface-implementation-errors"
},
{
"source_path_from_root": "/docs/csharp/misc/cs0737.md",
"redirect_url": "/dotnet/csharp/language-reference/compiler-messages/interface-implementation-errors"
},
{
"source_path_from_root": "/docs/csharp/misc/cs0738.md",
"redirect_url": "/dotnet/csharp/language-reference/compiler-messages/interface-implementation-errors"
},
{
"source_path_from_root": "/docs/csharp/language-reference/compiler-messages/cs0767.md",
"redirect_url": "/dotnet/csharp/language-reference/compiler-messages/ref-modifiers-errors"
Expand Down Expand Up @@ -1833,10 +1861,34 @@
"source_path_from_root": "/docs/csharp/misc/cs0457.md",
"redirect_url": "/dotnet/csharp/language-reference/compiler-messages/overload-resolution"
},
{
"source_path_from_root": "/docs/csharp/misc/cs0425.md",
"redirect_url": "/dotnet/csharp/language-reference/compiler-messages/interface-implementation-errors"
},
{
"source_path_from_root": "/docs/csharp/misc/cs0460.md",
"redirect_url": "/dotnet/csharp/language-reference/compiler-messages/interface-implementation-errors"
},
{
"source_path_from_root": "/docs/csharp/misc/cs0466.md",
"redirect_url": "/dotnet/csharp/language-reference/compiler-messages/params-arrays"
},
{
"source_path_from_root": "/docs/csharp/misc/cs0470.md",
"redirect_url": "/dotnet/csharp/language-reference/compiler-messages/interface-implementation-errors"
},
{
"source_path_from_root": "/docs/csharp/misc/cs0473.md",
"redirect_url": "/dotnet/csharp/language-reference/compiler-messages/interface-implementation-errors"
},
{
"source_path_from_root": "/docs/csharp/misc/cs0531.md",
"redirect_url": "/dotnet/csharp/language-reference/compiler-messages/interface-implementation-errors"
},
{
"source_path_from_root": "/docs/csharp/misc/cs0535.md",
"redirect_url": "/dotnet/csharp/language-reference/compiler-messages/interface-implementation-errors"
},
{
"source_path_from_root": "/docs/csharp/misc/cs0501.md",
"redirect_url": "/dotnet/csharp/language-reference/compiler-messages/partial-declarations"
Expand Down Expand Up @@ -1865,6 +1917,30 @@
"source_path_from_root": "/docs/csharp/misc/cs0526.md",
"redirect_url": "/dotnet/csharp/language-reference/compiler-messages/constructor-errors#constructor-declarations"
},
{
"source_path_from_root": "/docs/csharp/misc/cs0538.md",
"redirect_url": "/dotnet/csharp/language-reference/compiler-messages/interface-implementation-errors"
},
{
"source_path_from_root": "/docs/csharp/misc/cs0539.md",
"redirect_url": "/dotnet/csharp/language-reference/compiler-messages/interface-implementation-errors"
},
{
"source_path_from_root": "/docs/csharp/misc/cs0540.md",
"redirect_url": "/dotnet/csharp/language-reference/compiler-messages/interface-implementation-errors"
},
{
"source_path_from_root": "/docs/csharp/misc/cs0541.md",
"redirect_url": "/dotnet/csharp/language-reference/compiler-messages/interface-implementation-errors"
},
{
"source_path_from_root": "/docs/csharp/misc/cs0550.md",
"redirect_url": "/dotnet/csharp/language-reference/compiler-messages/interface-implementation-errors"
},
{
"source_path_from_root": "/docs/csharp/misc/cs0551.md",
"redirect_url": "/dotnet/csharp/language-reference/compiler-messages/interface-implementation-errors"
},
{
"source_path_from_root": "/docs/csharp/misc/cs0553.md",
"redirect_url": "/dotnet/csharp/language-reference/compiler-messages/overloaded-operator-errors"
Expand Down
52 changes: 0 additions & 52 deletions docs/csharp/language-reference/compiler-messages/cs0071.md

This file was deleted.

70 changes: 0 additions & 70 deletions docs/csharp/language-reference/compiler-messages/cs0106.md

This file was deleted.

76 changes: 0 additions & 76 deletions docs/csharp/language-reference/compiler-messages/cs0686.md

This file was deleted.

Loading