Skip to content

Conversation

@jkotas
Copy link
Member

@jkotas jkotas commented Nov 22, 2018

Delete references to AppDomainCompatSwitch. It was never supported in .NET Core.

Related to dotnet/coreclr#21157 (comment)

Delete references to AppDomainCompatSwitch. It was never supported in .NET Core.
@jkotas jkotas requested a review from mairaw as a code owner November 22, 2018 10:11
@jkotas
Copy link
Member Author

jkotas commented Nov 22, 2018

cc @vitek-karas

@richlander
Copy link
Member

Are the related usages in the referenced sample relevant?

One use: https://github.com/dotnet/samples/blob/master/core/hosting/host.cpp#L295-L304

@jkotas
Copy link
Member Author

jkotas commented Nov 24, 2018

Are the related usages in the referenced sample relevant?

They are not. I am cleaning them up in: dotnet/samples#477

@richlander
Copy link
Member

LGTM

Copy link
Contributor

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll merge your PR now, @jkotas

@rpetrusha rpetrusha merged commit b880853 into master Nov 26, 2018
@delete-merged-branch delete-merged-branch bot deleted the jkotas-patch-1 branch November 26, 2018 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants