- 
                Notifications
    
You must be signed in to change notification settings  - Fork 1.6k
 
Add performance and compatibility details to EtwManifestEventFormat and EtwSelfDescribingEventFormat docs #12000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…EtwSelfDescribingEventFormat docs Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>
Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>
Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR improves the documentation for the EventSourceSettings enumeration by clarifying the differences between manifest-based and self-describing event formats. The changes remove redundant text and add helpful context about performance characteristics and compatibility trade-offs.
- Removed redundant sentence in 
EtwManifestEventFormatsummary - Added performance and compatibility comparisons for both event format options
 - Added reference links to detailed documentation about event format differences
 
| 
           @noahfalk PTLA - this adds additional information you have mentioned in dotnet/runtime PR discussion a few days ago  | 
    
| 
           I thought the comments got synced from the source code. Is that just a one time thing and then future updates should happen here?  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Text looks good to me, my only question is if it belonged here or in the C# source comments. Thanks!
          
 dotnet-api-docs repo is the source of truth for documentation of assemblies with  Source comments are the source of truth for documentation of assemblies that are missing this property. More recently introduced assemblies are on this plan. Ideally, we would like to have the documentation in the source files for everything, but we have not been able to fund that work.  | 
    
| 
           Thanks @jkotas, thats much clearer now. I tried searching around a bit for that info earlier but failed to find it.  | 
    
          
 I hope dotnet/runtime#121271 will makes this information more discoverable.  | 
    
| 
           I also just proposed #12004 which would have most directly helped me find the info earlier.  | 
    
Adds trade-off information between
EtwManifestEventFormatandEtwSelfDescribingEventFormatas identified in dotnet/runtime#121180.Changes
These additions clarify the performance vs. compatibility trade-off when choosing event formats for EventSource configuration.
> [!WARNING]
>
>
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.