-
Notifications
You must be signed in to change notification settings - Fork 1.7k
CI Update - Updated baseline #12122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI Update - Updated baseline #12122
Conversation
Build.Reason:Manual by Genevieve Warren Build.Url:https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=580690&view=results source_repo.branch:master source_repo.url:https://apidrop.visualstudio.com/_git/binaries
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates XML documentation baselines, primarily to add inheritdoc tags for CopyTo and TryCopyTo methods now that a related issue has been fixed. The changes also include corrections to parameter documentation order to match actual method signatures, updates to interface member references (removing |System.Runtime.InteropServices.InAttribute suffixes), and reordering of altmember references.
- Added
inheritdoctags forCopyToandTryCopyTomethods across tensor types - Corrected parameter documentation order to match method signatures
- Updated interface member references to remove attribute suffixes
- Reordered
altmemberelements in various ASN1 and other documentation files
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| xml/System.Numerics.Tensors/Tensor`1.xml | Added inheritdoc tags, updated interface references, modified returns documentation for GetPinnedHandle |
| xml/System.Numerics.Tensors/TensorSpan`1.xml | Added inheritdoc tags and updated interface member references |
| xml/System.Numerics.Tensors/ReadOnlyTensorSpan`1.xml | Added inheritdoc tags and updated interface member references |
| xml/System.Numerics.Tensors/Tensor.xml | Corrected parameter documentation order for multiple methods |
| xml/System.Formats.Asn1/AsnWriter.xml | Reordered altmember references for consistency |
| xml/System.Formats.Asn1/AsnReader.xml | Reordered altmember references for consistency |
| xml/System.Formats.Asn1/AsnDecoder.xml | Reordered altmember references for consistency |
| xml/System.CommandLine/ParserConfiguration.xml | Added param element to EnablePosixBundling property (incorrect element type) |
| xml/Microsoft.Extensions.VectorData/VectorStore.xml | Reordered altmember references |
| xml/Microsoft.Extensions.Diagnostics.Metrics/MetricsBuilderExtensions.xml | Corrected parameter order |
| xml/Microsoft.Extensions.DependencyInjection/HealthChecksBuilderDelegateExtensions.xml | Corrected parameter order for multiple overloads |
| xml/Microsoft.Extensions.DependencyInjection/HealthChecksBuilderAddCheckExtensions.xml | Corrected parameter order |
| xml/Microsoft.Extensions.DependencyInjection/FromKeyedServicesAttribute.xml | Reordered altmember references |
| xml/Microsoft.Extensions.DependencyInjection.Extensions/ServiceCollectionDescriptorExtensions.xml | Corrected parameter order |
| xml/Microsoft.Extensions.Caching.Hybrid/HybridCache.xml | Corrected parameter order |
|
Build warnings are tracked by https://portal.microsofticm.com/imp/v5/incidents/details/720595622/summary. |
BillWagner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM @gewarren
when ready.
Build.Reason:Manual by Genevieve Warren
Build.Url:https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=580690&view=results
source_repo.branch:master
source_repo.url:https://apidrop.visualstudio.com/_git/binaries
Summary
Mostly to bring in inheritdoc tags for CopyTo/TryCopyTo now that https://dev.azure.com/ceapex/Engineering/_workitems/edit/1055155 is fixed.