Add warning to ZipFile.ExtractToDirectory and ExtractToDirectoryAsync docs#12355
Merged
Conversation
github-actions
Bot
added
the
needs-area-label
…toryAsync remarks Co-authored-by: rzikm <32671551+rzikm@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add security warning for ZipFile.ExtractToDirectory methods
Add zip-bomb security warning to ZipFile.ExtractToDirectory and ExtractToDirectoryAsync docs
Feb 27, 2026
rzikm
added
area-System.IO.Compression
and removed
needs-area-label
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-io-compression |
Member
|
cc @GrabYourPitchforks, @blowdart for wording |
rzikm
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds security warnings to all ZipFile.ExtractToDirectory and ExtractToDirectoryAsync methods, alerting developers that these convenience APIs don't enforce limits on uncompressed size or entry count, making them vulnerable to zip-bomb attacks when used with untrusted archives.
Changes:
- Added security warnings to 16 method overloads in
ZipFile.xml - Warning directs users to manually iterate entries using
ZipArchiveand validate limits before extraction - Applied consistent warning text across three different XML documentation formats (markdown, para, plain text)
blowdart
approved these changes
Feb 27, 2026
gewarren
reviewed
Feb 27, 2026
… fix encoding condition order Co-authored-by: rzikm <32671551+rzikm@users.noreply.github.com>
gewarren
approved these changes
Feb 28, 2026
Co-authored-by: gewarren <24882762+gewarren@users.noreply.github.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ExtractToDirectoryandExtractToDirectoryAsyncoverloads<format type="text/markdown">formatentryNameEncodingcondition description in two async overloads>in all 16 warning lines (> This method→> This method)🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.