Skip to content

Standardize NIST guidance sentence order in crypto XML docs#12526

Merged
gewarren merged 2 commits intocopilot/fix-incorrect-security-guidelinesfrom
copilot/sub-pr-12524
Apr 16, 2026
Merged

Standardize NIST guidance sentence order in crypto XML docs#12526
gewarren merged 2 commits intocopilot/fix-incorrect-security-guidelinesfrom
copilot/sub-pr-12524

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 16, 2026

This stacked PR addresses review feedback on #12524 by updating the exact NIST guidance sentence wherever it appears in the affected crypto docs. The goal is a wording-only normalization with no semantic changes.

  • Scope of change

    • Updated all matching occurrences in xml/System.Security.Cryptography/* from:
      • See [NIST SP 800-131A Rev. 2](...) for guidance on approved algorithms.
    • To:
      • For guidance on approved algorithms, see [NIST SP 800-131A Rev. 2](...).
  • What was touched

    • 18 XML doc files in System.Security.Cryptography.
    • Changes are limited to sentence ordering in existing warning/remarks text; links and surrounding guidance remain intact.
  • Example update

    Due to collision problems with MD5, Microsoft recommends using a NIST-approved hash function.
    For guidance on approved algorithms, see [NIST SP 800-131A Rev. 2](https://csrc.nist.gov/pubs/sp/800/131/a/r2/final).

Copilot AI changed the title [WIP] [WIP] Address feedback on crypto algorithm recommendations in PR #12524 Standardize NIST guidance sentence order in crypto XML docs Apr 16, 2026
Copilot AI requested a review from gewarren April 16, 2026 18:08
@github-actions github-actions bot added the area-System.Security Issues related to security practices for .NET developers. label Apr 16, 2026
@dotnet-policy-service
Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/area-system-security, @vcsjones

@gewarren gewarren marked this pull request as ready for review April 16, 2026 18:51
@gewarren gewarren requested a review from a team as a code owner April 16, 2026 18:52
@gewarren gewarren merged commit 5b93c40 into copilot/fix-incorrect-security-guidelines Apr 16, 2026
5 checks passed
@gewarren gewarren deleted the copilot/sub-pr-12524 branch April 16, 2026 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-System.Security Issues related to security practices for .NET developers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants