Skip to content

Conversation

@mairaw
Copy link
Contributor

@mairaw mairaw commented Aug 22, 2018

Loc is having issues with the tag on this line and I imagine it could be that the tag was on the same line as the code block.

Internal review url

Copy link

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You can merge when you're ready, @mairaw.

@mairaw
Copy link
Contributor Author

mairaw commented Aug 23, 2018

@rpetrusha actually @dend pointed out that we had some migration issue with this section:
image

so made a different fix. trying to see if markdown will work here.

@mairaw mairaw changed the title move end tag position fix notes to inheritors section Aug 23, 2018
@mairaw mairaw merged commit bd6ddef into master Aug 24, 2018
@mairaw mairaw deleted the mairaw-patch-1 branch August 24, 2018 07:29
@mairaw mairaw self-assigned this Aug 24, 2018
@nokura
Copy link

nokura commented Aug 27, 2018

Thank you so much @mairaw. I cannot thank you enough for your support for Loc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants