-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Explain event waited for specified number of ms #5434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Docs Build status updates of commit 958441c: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
| <Docs> | ||
| <param name="item">The item to be added to the collection.</param> | ||
| <param name="millisecondsTimeout">The number of milliseconds to wait, or <see cref="F:System.Threading.Timeout.Infinite" /> (-1) to wait indefinitely.</param> | ||
| <param name="millisecondsTimeout">The number of milliseconds to wait for thread-safe access to the collection, or <see cref="F:System.Threading.Timeout.Infinite" /> (-1) to wait indefinitely.</param> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would change the wording slightly, it is already given that any method in class guarantees thread-safe access.
| <param name="millisecondsTimeout">The number of milliseconds to wait for thread-safe access to the collection, or <see cref="F:System.Threading.Timeout.Infinite" /> (-1) to wait indefinitely.</param> | |
| <param name="millisecondsTimeout">The number of milliseconds to wait for the collection to accept the item, or <see cref="F:System.Threading.Timeout.Infinite" /> (-1) to wait indefinitely.</param> |
|
CC @layomia |
|
Docs Build status updates of commit 5e39573: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
|
Docs Build status updates of commit bc55393: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
|
Docs Build status updates of commit 48d844c: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
|
Docs Build status updates of commit 48d844c: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
Summary
Without access to reference sources, it is not intuitively clear what is waited for. Source documents that it is a wait on a semaphore for access to the collection (occupied nodes).