Skip to content

Conversation

@monty241
Copy link
Contributor

Summary

Without access to reference sources, it is not intuitively clear what is waited for. Source documents that it is a wait on a semaphore for access to the collection (occupied nodes).

@opbld30
Copy link

opbld30 commented Mar 13, 2021

Docs Build status updates of commit 958441c:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Collections.Concurrent/BlockingCollection`1.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

<Docs>
<param name="item">The item to be added to the collection.</param>
<param name="millisecondsTimeout">The number of milliseconds to wait, or <see cref="F:System.Threading.Timeout.Infinite" /> (-1) to wait indefinitely.</param>
<param name="millisecondsTimeout">The number of milliseconds to wait for thread-safe access to the collection, or <see cref="F:System.Threading.Timeout.Infinite" /> (-1) to wait indefinitely.</param>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would change the wording slightly, it is already given that any method in class guarantees thread-safe access.

Suggested change
<param name="millisecondsTimeout">The number of milliseconds to wait for thread-safe access to the collection, or <see cref="F:System.Threading.Timeout.Infinite" /> (-1) to wait indefinitely.</param>
<param name="millisecondsTimeout">The number of milliseconds to wait for the collection to accept the item, or <see cref="F:System.Threading.Timeout.Infinite" /> (-1) to wait indefinitely.</param>

@antonfirsov
Copy link
Contributor

CC @layomia

@eiriktsarpalis
Copy link
Member

Hi @monty241, would you be able to take a look at the feedback? Thanks

cc @gewarren

@monty241
Copy link
Contributor Author

Hi @monty241, would you be able to take a look at the feedback? Thanks

cc @gewarren

Alternative is also fine. It answers the question I've had.

@opbld34
Copy link

opbld34 commented Mar 30, 2021

Docs Build status updates of commit 5e39573:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Collections.Concurrent/BlockingCollection`1.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@opbld30
Copy link

opbld30 commented Mar 30, 2021

Docs Build status updates of commit bc55393:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Collections.Concurrent/BlockingCollection`1.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@opbld30
Copy link

opbld30 commented Mar 31, 2021

Docs Build status updates of commit 48d844c:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Collections.Concurrent/BlockingCollection`1.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@opbld33
Copy link

opbld33 commented Mar 31, 2021

Docs Build status updates of commit 48d844c:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Collections.Concurrent/BlockingCollection`1.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@gewarren gewarren merged commit f33aab6 into dotnet:main Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants