Skip to content

Conversation

@sywhang
Copy link
Contributor

@sywhang sywhang commented Mar 30, 2021

Summary

There is a useless line of code in the sample code for EventSource. Removing this to avoid causing any confusion.

@sywhang sywhang requested a review from a team as a code owner March 30, 2021 22:53
@ghost ghost added the area-System.Security Issues related to security practices for .NET developers. label Mar 30, 2021
@opbld34
Copy link

opbld34 commented Mar 30, 2021

Docs Build status updates of commit d4dc4a0:

✅ Validation status: passed

File Status Preview URL Details
samples/snippets/csharp/VS_Snippets_CLR/etwtracesmall/cs/program.cs ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

{
static void Main(string[] args)
{
string name = MyCompanyEventSource.GetName(typeof(MyCompanyEventSource));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this line also useless? VB snippet doesn't have it either.

@opbld30
Copy link

opbld30 commented Mar 31, 2021

Docs Build status updates of commit cdd2961:

✅ Validation status: passed

File Status Preview URL Details
samples/snippets/csharp/VS_Snippets_CLR/etwtracesmall/cs/program.cs ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@sywhang sywhang merged commit 36ead10 into dotnet:main Apr 1, 2021
@sywhang sywhang deleted the dev/suwhang/fix-eventsource-sample branch April 1, 2021 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-System.Security Issues related to security practices for .NET developers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants