Skip to content

Conversation

@karelz
Copy link
Member

@karelz karelz commented Oct 20, 2021

Clarify that UseSocketsHttpHandler switch is available only on 2.1-3.1 and not 5.0+

Makes the doc consistent with SocketsHttpHandler remarks - https://docs.microsoft.com/en-us/dotnet/api/system.net.http.socketshttphandler#remarks

Clarify that UseSocketsHttpHandler switch is available only on 2.1-3.1 and not 5.0+
@karelz karelz requested a review from gewarren October 20, 2021 12:18
@karelz karelz requested a review from a team as a code owner October 20, 2021 12:18
@ghost ghost added the area-System.Net.Http label Oct 20, 2021
@ghost
Copy link

ghost commented Oct 20, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Clarify that UseSocketsHttpHandler switch is available only on 2.1-3.1 and not 5.0+

Makes the doc consistent with SocketsHttpHandler remarks - https://docs.microsoft.com/en-us/dotnet/api/system.net.http.socketshttphandler#remarks

Author: karelz
Assignees: -
Labels:

area-System.Net.Http

Milestone: -

@opbld33
Copy link

opbld33 commented Oct 20, 2021

Docs Build status updates of commit 1b4c6fe:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Net.Http/HttpClientHandler.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit to consider.

Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@opbld33
Copy link

opbld33 commented Oct 21, 2021

Docs Build status updates of commit 90e1ac2:

❌ Validation status: errors

Please follow instructions here which may help to resolve issue.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@gewarren
Copy link
Contributor

Close/reopen for fresh build.

@gewarren gewarren closed this Oct 21, 2021
@gewarren gewarren reopened this Oct 21, 2021
@opbld31
Copy link

opbld31 commented Oct 21, 2021

Docs Build status updates of commit 90e1ac2:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Net.Http/HttpClientHandler.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@gewarren gewarren merged commit 0e12f0a into main Oct 21, 2021
@gewarren gewarren deleted the karelz-patch-1 branch October 21, 2021 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants