Skip to content

Conversation

@buyaa-n
Copy link
Contributor

@buyaa-n buyaa-n commented Sep 23, 2022

Add missing docs in FieldTypeEncoder.CustomModifiers, ObsoletedOSPlatformAttribute

Contribute to dotnet/runtime#76049

System.Reflection.Metadata.Ecma335
API Summary Parameters TypeParameters ReturnValue
M:System.Reflection.Metadata.Ecma335.FieldTypeEncoder.CustomModifiers Present NA NA Missing
System.Runtime.Versioning
API Summary Parameters TypeParameters ReturnValue
M:System.Runtime.Versioning.ObsoletedOSPlatformAttribute.#ctor(System.String,System.String) Missing Missing NA NA
M:System.Runtime.Versioning.ObsoletedOSPlatformAttribute.#ctor(System.String) Missing Missing NA NA
P:System.Runtime.Versioning.ObsoletedOSPlatformAttribute.Message Missing NA NA NA
P:System.Runtime.Versioning.ObsoletedOSPlatformAttribute.Url Missing NA NA NA

ObsoletedInOSPlatformAttribute missing dos previously added with https://github.com/dotnet/dotnet-api-docs/pull/8302/files, but the API changes name from ObsoletedInOSPlatformAttribute -> ObsoletedOSPlatformAttribute and that update lost and here adding them back

@buyaa-n buyaa-n requested a review from a team as a code owner September 23, 2022 21:55
@ghost ghost assigned buyaa-n Sep 23, 2022
@ghost
Copy link

ghost commented Sep 23, 2022

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@opbld32
Copy link

opbld32 commented Sep 23, 2022

Docs Build status updates of commit e544a1f:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Reflection.Metadata.Ecma335/FieldTypeEncoder.xml ✅Succeeded View
xml/System.Runtime.Versioning/ObsoletedOSPlatformAttribute.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@opbld30
Copy link

opbld30 commented Sep 25, 2022

Docs Build status updates of commit 9d03ee8:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Reflection.Metadata.Ecma335/FieldTypeEncoder.xml ✅Succeeded View
xml/System.Runtime.Versioning/ObsoletedOSPlatformAttribute.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@buyaa-n buyaa-n merged commit f81fc7e into dotnet:main Sep 26, 2022
@buyaa-n buyaa-n deleted the rc1-missing-doc branch September 26, 2022 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants