Details about AutomaticDecompression #8472

ManickaP · 2022-10-06T15:59:01Z

ghost · 2022-10-06T15:59:21Z

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Author:	ManickaP
Assignees:	ManickaP
Labels:	`area-System.Net.Http`
Milestone:	-

opbld33 · 2022-10-06T16:03:36Z

Learn Build status updates of commit 10d55f8:

❌ Validation status: errors

Please follow instructions here which may help to resolve issue.

File	Status	Preview URL	Details
	❌Error		Details
xml/System.Net.Http/SocketsHttpHandler.xml	❌Error		Details

Line 0, Column 0: [Error: ECMA2Yaml_File_LoadFailed] Failed to load 1 files, aborting...

xml/System.Net.Http/SocketsHttpHandler.xml

Line 0, Column 0: [Error: ECMA2Yaml_InternalError]

Intenal Several Error: System.Xml.XmlException: The 'remarks' start tag on line 183 position 10 does not match the end tag of 'Docs'. Line 193, position 9.
   at System.Xml.XmlTextReaderImpl.Throw(Exception e)
   at System.Xml.XmlTextReaderImpl.Throw(String res, String[] args)
   at System.Xml.XmlTextReaderImpl.ThrowTagMismatch(NodeData startTag)
   at System.Xml.XmlTextReaderImpl.ParseEndElement()
   at System.Xml.XmlTextReaderImpl.ParseElementContent()
   at System.Xml.Linq.XContainer.ReadContentFrom(XmlReader r)
   at System.Xml.Linq.XDocument.Load(XmlReader reader, LoadOptions options)
   at System.Xml.Linq.XDocument.Parse(String text, LoadOptions options)
   at ECMA2Yaml.ECMALoader.LoadType(FileItem typeFile)
   at ECMA2Yaml.ECMALoader.LoadTypes(String basePath, Namespace ns)

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Try searching the learn.microsoft.com contributor guides
Post your question in the Learn support channel

opbld33 · 2022-10-07T09:16:55Z

Learn Build status updates of commit 3a33a26:

✅ Validation status: passed

File	Status	Preview URL	Details
xml/System.Net.Http/HttpClientHandler.xml	✅Succeeded	View
xml/System.Net.Http/SocketsHttpHandler.xml	✅Succeeded	View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Try searching the learn.microsoft.com contributor guides
Post your question in the Learn support channel

opbld31 · 2022-10-07T09:51:47Z

Learn Build status updates of commit f6d36b2:

✅ Validation status: passed

File	Status	Preview URL	Details
xml/System.Net.Http/HttpClientHandler.xml	✅Succeeded	View
xml/System.Net.Http/SocketsHttpHandler.xml	✅Succeeded	View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Try searching the learn.microsoft.com contributor guides
Post your question in the Learn support channel

liveans

LGTM!

xml/System.Net.Http/HttpClientHandler.xml

xml/System.Net.Http/SocketsHttpHandler.xml

Co-authored-by: Ahmet İbrahim AKSOY <aaksoy@microsoft.com>

opbld32 · 2022-10-07T11:38:00Z

Learn Build status updates of commit 64b1e4b:

✅ Validation status: passed

File	Status	Preview URL	Details
xml/System.Net.Http/HttpClientHandler.xml	✅Succeeded	View
xml/System.Net.Http/SocketsHttpHandler.xml	✅Succeeded	View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Try searching the learn.microsoft.com contributor guides
Post your question in the Learn support channel

opbld34 · 2022-10-07T12:19:14Z

Learn Build status updates of commit 5e11d91:

✅ Validation status: passed

File	Status	Preview URL	Details
xml/System.Net.Http/HttpClientHandler.xml	✅Succeeded	View
xml/System.Net.Http/SocketsHttpHandler.xml	✅Succeeded	View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Try searching the learn.microsoft.com contributor guides
Post your question in the Learn support channel

stephentoub · 2022-10-10T13:46:44Z

xml/System.Net.Http/HttpClientHandler.xml


 ## Remarks
+ Automatic decompression works only on the top most compression. So if the content is compressed multiple times, only the last compression will be decompressed.
+ For example, for a reponse with `Content-Encoding: gzip, br` header, the content will only be decompressed using Brotli, leaving the still gzipped content in the <xref:System.Net.Http.HttpResponseMessage.Content>.


reponse

response

stephentoub · 2022-10-10T13:48:10Z

xml/System.Net.Http/HttpClientHandler.xml


 ## Remarks
+ Automatic decompression works only on the top most compression. So if the content is compressed multiple times, only the last compression will be decompressed.
+ For example, for a reponse with `Content-Encoding: gzip, br` header, the content will only be decompressed using Brotli, leaving the still gzipped content in the <xref:System.Net.Http.HttpResponseMessage.Content>.


For example, for a reponse with Content-Encoding: gzip, br header

"For example, for a response with a Content-Encoding: gzip, br header that contains content first compressed with gzip and then that compressed content Brotli compressed,"

stephentoub · 2022-10-10T13:48:35Z

xml/System.Net.Http/HttpClientHandler.xml

+ Automatic decompression works only on the top most compression. So if the content is compressed multiple times, only the last compression will be decompressed.
+ For example, for a reponse with `Content-Encoding: gzip, br` header, the content will only be decompressed using Brotli, leaving the still gzipped content in the <xref:System.Net.Http.HttpResponseMessage.Content>.
+
+ Setting automatic decompression to anything else than <xref:System.Net.DecompressionMethods.None> will cause adding `Accept-Encoding` header with the set values into every outgoing <xref:System.Net.Http.HttpRequestMessage>.


to anything else than

"to anything other than"

stephentoub · 2022-10-10T13:49:06Z

xml/System.Net.Http/HttpClientHandler.xml

+ Automatic decompression works only on the top most compression. So if the content is compressed multiple times, only the last compression will be decompressed.
+ For example, for a reponse with `Content-Encoding: gzip, br` header, the content will only be decompressed using Brotli, leaving the still gzipped content in the <xref:System.Net.Http.HttpResponseMessage.Content>.
+
+ Setting automatic decompression to anything else than <xref:System.Net.DecompressionMethods.None> will cause adding `Accept-Encoding` header with the set values into every outgoing <xref:System.Net.Http.HttpRequestMessage>.


will cause adding Accept-Encoding header with

"will result in adding an Accept-Encoding header with"

stephentoub · 2022-10-10T13:49:18Z

xml/System.Net.Http/SocketsHttpHandler.xml

+        <remarks>
+          <format type="text/markdown"><![CDATA[
+
+## Remarks


Same comments as above.

ManickaP requested a review from a team as a code owner October 6, 2022 15:59

ghost assigned ManickaP Oct 6, 2022

ghost added the area-System.Net.Http label Oct 6, 2022

ManickaP force-pushed the mapichov/automatic-decompression branch 2 times, most recently from 3a33a26 to f6d36b2 Compare October 7, 2022 08:51

Details about AutomaticDecompression

f6d36b2

liveans approved these changes Oct 7, 2022

View reviewed changes

xml/System.Net.Http/HttpClientHandler.xml Outdated Show resolved Hide resolved

xml/System.Net.Http/SocketsHttpHandler.xml Outdated Show resolved Hide resolved

ManickaP and others added 2 commits October 7, 2022 13:07

Update xml/System.Net.Http/HttpClientHandler.xml

64b1e4b

Co-authored-by: Ahmet İbrahim AKSOY <aaksoy@microsoft.com>

Update xml/System.Net.Http/SocketsHttpHandler.xml

5e11d91

Co-authored-by: Ahmet İbrahim AKSOY <aaksoy@microsoft.com>

ManickaP enabled auto-merge (squash) October 7, 2022 11:08

ManickaP merged commit a4d95ef into dotnet:main Oct 7, 2022

ManickaP deleted the mapichov/automatic-decompression branch October 7, 2022 12:48

stephentoub reviewed Oct 10, 2022

View reviewed changes

xml/System.Net.Http/SocketsHttpHandler.xml

<remarks>

<format type="text/markdown"><![CDATA[

## Remarks

Copy link

Member

stephentoub Oct 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comments as above.

ManickaP mentioned this pull request Oct 11, 2022

Typos and wording #8497

Merged

Details about AutomaticDecompression #8472

Details about AutomaticDecompression #8472

Uh oh!

Conversation

ManickaP commented Oct 6, 2022

Uh oh!

ghost commented Oct 6, 2022

Uh oh!

opbld33 commented Oct 6, 2022

❌ Validation status: errors

xml/System.Net.Http/SocketsHttpHandler.xml

Uh oh!

opbld33 commented Oct 7, 2022

✅ Validation status: passed

Uh oh!

opbld31 commented Oct 7, 2022

✅ Validation status: passed

Uh oh!

liveans left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

opbld32 commented Oct 7, 2022

✅ Validation status: passed

Uh oh!

opbld34 commented Oct 7, 2022

✅ Validation status: passed

Uh oh!

stephentoub Oct 10, 2022

Choose a reason for hiding this comment

Uh oh!

stephentoub Oct 10, 2022

Choose a reason for hiding this comment

Uh oh!

stephentoub Oct 10, 2022

Choose a reason for hiding this comment

Uh oh!

stephentoub Oct 10, 2022

Choose a reason for hiding this comment

Uh oh!

stephentoub Oct 10, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants