Skip to content

Conversation

@softwarepronto
Copy link
Contributor

Summary

An example of subscribe event is provided for the WebClient events. Some events have the event handler method in the documentation (DownloadFileCompleted, DownloadProgressChanged, and UploadProgressChanged). Some events are missing the method specified when the event is subscribed. This includes DownloadDataCompleted which is missing the method to when the event was subscribed. DownloadDataCompleted was fixed to include the missing event handler method using the same pattern as UploadProgressChanged (a code section for the subscribe and a second code section for the event handler method).

Fixes #Issue_Number (if available)

An example of subscribe event is provided for the WebClient events. Some events have the event handler method in the documentation (DownloadFileCompleted, DownloadProgressChanged, and UploadProgressChanged). Some events are missing the method specified when the event is subscribed. This includes DownloadDataCompleted which is missing the method to when the event was subscribed. DownloadDataCompleted was fixed to include the missing event handler method using the same pattern as UploadProgressChanged (a code section for the subscribe and a second code section for the event handler method)
@softwarepronto softwarepronto requested a review from a team as a code owner October 22, 2022 06:15
@ghost ghost added community-contribution Indicates that the PR has been added by a community member area-System.Net labels Oct 22, 2022
@ghost
Copy link

ghost commented Oct 22, 2022

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Summary

An example of subscribe event is provided for the WebClient events. Some events have the event handler method in the documentation (DownloadFileCompleted, DownloadProgressChanged, and UploadProgressChanged). Some events are missing the method specified when the event is subscribed. This includes DownloadDataCompleted which is missing the method to when the event was subscribed. DownloadDataCompleted was fixed to include the missing event handler method using the same pattern as UploadProgressChanged (a code section for the subscribe and a second code section for the event handler method).

Fixes #Issue_Number (if available)

Author: softwarepronto
Assignees: -
Labels:

area-System.Net, community-contribution

Milestone: -

@opbld33
Copy link

opbld33 commented Oct 22, 2022

Learn Build status updates of commit c69a4d3:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Net/WebClient.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Copy link
Member

@rzikm rzikm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

PS: Next time, you can bundle multiple small like-minded changes to a single PR, there was no need to open new PR for every missing handler implementation :)

@rzikm rzikm merged commit db8f1d7 into dotnet:main Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-System.Net community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants